Implement receiving mode #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Receive button click shows a dialog notifying the user that we are waiting for a device to connect - Enable cancel button to cancel the dialog - Send and receive buttons are disabled when the dialog is shown
- Add Nearby Connections API - Add Timber dependency - Add P2PLibrary which will enable adding implementation of interfaces and requirements for the library - Instantiate the P2pModeSelectInteractor in the P2pModeSelectPresenter
1. Enforce username when initialising username 2. Make the presenter testable by allowing the interactor as a param 3. Enforce initialising the P2PLibrary by introducing a RuntimeException if it is accessed without being intialised. This means that it will fail fast during developmental testing since getInstance has to be called whenever interacting with the library
809eab1 to
7d2b8cb
Compare
1. Add Nearby Connections API permissions check & request 2. Check if location is enabled & request for enabling it if not 3. Add onResume and onActivityResult handlers for the activity 4. Add Permissions util class
Also added P2pModeSelectInteractor tests
Code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1