Unregister click listener onStop

- Change Constants class to interface instead of abstract class
opensrp · Mar 14, 2019 · 887460b · 887460b
1 parent f41690f
commit 887460b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/p2p-sync/src/main/java/org/smartregister/p2p/activity/P2pModeSelectActivity.java b/p2p-sync/src/main/java/org/smartregister/p2p/activity/P2pModeSelectActivity.java
@@ -67,16 +67,12 @@ protected void onStart() {
         super.onStart();
         initializePresenter();
 
-        sendButton.setOnClickListener(null);
-        receiveButton.setOnClickListener(null);
-
         sendButton.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View v) {
                 presenter.onSendButtonClicked();
             }
         });
-
         receiveButton.setOnClickListener(new View.OnClickListener() {
             @Override
             public void onClick(View v) {
@@ -307,6 +303,8 @@ public boolean removeOnActivityRequestPermissionHandler(@NonNull OnActivityReque
     protected void onStop() {
         super.onStop();
 
+        sendButton.setOnClickListener(null);
+        receiveButton.setOnClickListener(null);
 
         presenter.onStop();
     }

diff --git a/p2p-sync/src/main/java/org/smartregister/p2p/util/Constants.java b/p2p-sync/src/main/java/org/smartregister/p2p/util/Constants.java
@@ -6,12 +6,12 @@
  * Created by Ephraim Kigamba - ekigamba@ona.io on 11/03/2019
  */
 
-public abstract class Constants {
+public interface Constants {
 
-    public static final Strategy STRATEGY = Strategy.P2P_STAR;
+    Strategy STRATEGY = Strategy.P2P_STAR;
 
-    public abstract static class RQ_CODE {
-        public static final int PERMISSIONS = 2;
-        public static final int LOCATION_SETTINGS = 3;
+    interface RQ_CODE {
+        int PERMISSIONS = 2;
+        int LOCATION_SETTINGS = 3;
     }
 }