Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The size of the Event description TextCtrl is too small. Can the proportion attribute be set to 1? #3

Open
hwf1324 opened this issue Nov 14, 2023 · 3 comments · May be fixed by #6
Open

Comments

@hwf1324
Copy link
Contributor

hwf1324 commented Nov 14, 2023

As the title suggests, the Event description text box is a bit small.

I have studied the code of NVDA guiHelper for a while, but I cannot find a way to add another control and set the proportion or flag properties when using LabeledControlHelper

XLTechie pushed a commit that referenced this issue Mar 20, 2024
Attempting to fix a reported bug (#3).
@XLTechie
Copy link
Collaborator

XLTechie commented Mar 22, 2024

@hwf1324 Here is a beta version that might solve this problem. It is also 24.1.100 in the Add-on Store beta channel.

I can't tell if it solves it or not, because I can't look at it.

Please let me know.

@hwf1324
Copy link
Contributor Author

hwf1324 commented Mar 22, 2024

@hwf1324 Here is a beta version that might solve this problem. It is also 24.1.100 in the Add-on Store beta channel.

I can't tell if it solves it or not, because I can't look at it.

Please let me know.

@XLTechie

Unfortunately it doesn't solve the problem. I installed version 24.1.100 and the event description text box is still the same size.

The contentsSizer is vertical, so the proportion property is useless as it only controls the scaling of the BoxSizer along the main direction.

I created a PR that solves this problem.

@hwf1324
Copy link
Contributor Author

hwf1324 commented Mar 22, 2024

Another problem is that the current table and description in the vertical proportion of the description of some not high enough, can only display two or three lines of text, if you can set the description of the height of the proportion of higher would be better.

@XLTechie XLTechie linked a pull request Mar 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants