Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add types package.json exports #60

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

binodnepali
Copy link
Member

Description

This PR fixes type declaration not found in ts project.

Related Issue

Fixes #59

Type of Change

Please mark the appropriate option below to describe the type of change your pull request introduces:

  • Bug fix
  • New feature
  • Enhancement
  • Documentation update
  • Refactor
  • Other (please specify)

Checklist

  • I have used semantic commit messages.
    Examples: "fix: Fixed foobar bug", "feat(accounts): Added foobar feature".
  • I have added/updated the necessary documentation on README.md.
  • I have updated CHANGELOG.md for the significant changes.
  • I have added appropriate test cases (if applicable) to ensure the changes are functioning correctly.
  • My pull request has a clear title and description.

Additional Notes

[Add any additional notes or context that you think the reviewers should know about.]

By submitting this pull request, I confirm that I have read and complied with the contribution guidelines of this project.

@rubiin
Copy link
Member

rubiin commented Sep 12, 2023

LGTM

@aj3sh aj3sh merged commit 86b68ca into opensource-nepal:main Sep 13, 2023
@binodnepali binodnepali deleted the fix-ts-error branch September 13, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript could not find module declaration to resolve typing.
3 participants