Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

"Promote" button in OSIO pipeline calls launcher-backend #2093

Open
gastaldi opened this issue Jan 29, 2018 · 38 comments
Open

"Promote" button in OSIO pipeline calls launcher-backend #2093

gastaldi opened this issue Jan 29, 2018 · 38 comments

Comments

@gastaldi
Copy link
Member

gastaldi commented Jan 29, 2018

As part of the merge initiative with the forked generator-backend, we noticed that the legacy code contains some code that proxies requests to the user Jenkins.

IMHO that doesn't make sense that service to exist in launcher-backend, since launcher functionality ends after the booster is deployed. We need to move that code somewhere else. What would be the appropriate project to live on?

@gastaldi
Copy link
Member Author

Assigning to the platform team to start discussion about it

@gastaldi
Copy link
Member Author

My gut tells me this service should belong to CD, but I need someone to confirm

@joshuawilson
Copy link
Member

This is for CD team. cc @chmouel @rupalibehera

@gastaldi
Copy link
Member Author

Made SEV-2 because we're refactoring the launcher-backend and that will be gone after that

@joshuawilson
Copy link
Member

So you want it fixed before you refactor it and it is gone?

@gastaldi
Copy link
Member Author

Yes, does that make sense?

@bartoszmajsak
Copy link
Contributor

Refactoring is by definition changing internal structure and preserving the behaviour - so removing some functionality without introducing new service providing the same is a no-go.

@joshuawilson
Copy link
Member

and why should someone fix something that is going away?

@gastaldi
Copy link
Member Author

It's not going away, the UI still needs it. It needs to be moved to another project. It doesn't make sense to be where it is right now

@qodfathr
Copy link
Collaborator

I though we were reserving SEVs for bugs. This issue needs a type.

@chmouel
Copy link

chmouel commented Apr 20, 2018

Just updating on this, part of the F2F we decided to start to work on this, we are planning to ave a REST server for clients (here is launcher-backend) to call for build related operations. I will update this issue as soon I will have more documentation to share,

@gastaldi
Copy link
Member Author

gastaldi commented May 9, 2018

Given that the Jenkins may be idled and that @aslakknutsen confirmed that the proxy should be queried instead (see fabric8-services/fabric8-jenkins-proxy#206 (comment)) , I'd suggest to increase the priority on this issue (/cc @joshuawilson).

As of fabric8-launcher/launcher-application#390 we're removing the launcher-backend code that talks to Jenkins and the UI needs to change to talk to the jenkins-proxy URL directly instead (https://github.com/fabric8-ui/fabric8-ui/blob/master/src/a-runtime-console/kubernetes/ui/pipeline/input-action-dialog/input-action-dialog.component.ts#L72) as it already does in fabric8-ui/fabric8-ui#2889.

@joshuawilson
Copy link
Member

joshuawilson commented May 9, 2018

type/task do NOT get severity labels. We can mark it as a crucial dependency.

gastaldi added a commit to gastaldi/fabric8-ui that referenced this issue May 9, 2018
The pipeline button no longer calls the launcher-backend directly.

Fixes openshiftio/openshift.io#2093
gastaldi added a commit to gastaldi/fabric8-ui that referenced this issue May 9, 2018
The pipeline button no longer calls the launcher-backend directly.

Fixes openshiftio/openshift.io#2093

Signed-off-by: George Gastaldi <gegastaldi@gmail.com>
gastaldi added a commit to gastaldi/fabric8-ui that referenced this issue May 10, 2018
The pipeline button no longer calls the launcher-backend directly.

Fixes openshiftio/openshift.io#2093

Signed-off-by: George Gastaldi <gegastaldi@gmail.com>
@gastaldi gastaldi reopened this May 23, 2018
@gastaldi
Copy link
Member Author

fabric8-launcher/launcher-application#390 just refactors the functionality to use the updated API in launcher-backend. The functionality must still be moved to the build team domain or replaced when Build.next comes up

@bartoszmajsak
Copy link
Contributor

bartoszmajsak commented Oct 18, 2018

We introduced JWT validation in Launcher Backend and it seems this is the only place causing e2e tests to fail. For the moment the change has been reverted, but it needs to be addressed urgently.

/cc @sthaha @sbose78 @alexeykazakov @ldimaggi

@bartoszmajsak
Copy link
Contributor

bartoszmajsak commented Oct 18, 2018

It seems that calls from https://github.com/fabric8-ui/fabric8-ui/blob/master/src/a-runtime-console/kubernetes/ui/pipeline/input-action-dialog/input-action-dialog.component.ts#L61-L77 do not have X-App: OSIO in the headers. That results in Launcher Backend assuming it's a call from Standalone are trying to validate that against RHD KeyCloak keys.

@bartoszmajsak
Copy link
Contributor

We found the root cause #4453, but I keep this one open as it's really not the way it should be.

@hrishin
Copy link

hrishin commented Oct 20, 2018

@chmouel I think we should consider this API for build service.

@piyush-garg
Copy link
Collaborator

Removing SEV-2 label as this is task not bug.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests