-
Notifications
You must be signed in to change notification settings - Fork 66
"Promote" button in OSIO pipeline calls launcher-backend #2093
Comments
Assigning to the platform team to start discussion about it |
My gut tells me this service should belong to CD, but I need someone to confirm |
This is for CD team. cc @chmouel @rupalibehera |
Made SEV-2 because we're refactoring the launcher-backend and that will be gone after that |
So you want it fixed before you refactor it and it is gone? |
Yes, does that make sense? |
Refactoring is by definition changing internal structure and preserving the behaviour - so removing some functionality without introducing new service providing the same is a no-go. |
and why should someone fix something that is going away? |
It's not going away, the UI still needs it. It needs to be moved to another project. It doesn't make sense to be where it is right now |
I though we were reserving SEVs for bugs. This issue needs a |
Just updating on this, part of the F2F we decided to start to work on this, we are planning to ave a REST server for clients (here is launcher-backend) to call for build related operations. I will update this issue as soon I will have more documentation to share, |
Given that the Jenkins may be idled and that @aslakknutsen confirmed that the proxy should be queried instead (see fabric8-services/fabric8-jenkins-proxy#206 (comment)) , I'd suggest to increase the priority on this issue (/cc @joshuawilson). As of fabric8-launcher/launcher-application#390 we're removing the launcher-backend code that talks to Jenkins and the UI needs to change to talk to the jenkins-proxy URL directly instead (https://github.com/fabric8-ui/fabric8-ui/blob/master/src/a-runtime-console/kubernetes/ui/pipeline/input-action-dialog/input-action-dialog.component.ts#L72) as it already does in fabric8-ui/fabric8-ui#2889. |
|
The pipeline button no longer calls the launcher-backend directly. Fixes openshiftio/openshift.io#2093
The pipeline button no longer calls the launcher-backend directly. Fixes openshiftio/openshift.io#2093 Signed-off-by: George Gastaldi <gegastaldi@gmail.com>
The pipeline button no longer calls the launcher-backend directly. Fixes openshiftio/openshift.io#2093 Signed-off-by: George Gastaldi <gegastaldi@gmail.com>
fabric8-launcher/launcher-application#390 just refactors the functionality to use the updated API in launcher-backend. The functionality must still be moved to the build team domain or replaced when Build.next comes up |
We introduced JWT validation in Launcher Backend and it seems this is the only place causing e2e tests to fail. For the moment the change has been reverted, but it needs to be addressed urgently. |
It seems that calls from https://github.com/fabric8-ui/fabric8-ui/blob/master/src/a-runtime-console/kubernetes/ui/pipeline/input-action-dialog/input-action-dialog.component.ts#L61-L77 do not have |
We found the root cause #4453, but I keep this one open as it's really not the way it should be. |
@chmouel I think we should consider this API for build service. |
Removing SEV-2 label as this is task not bug. |
As part of the merge initiative with the forked generator-backend, we noticed that the legacy code contains some code that proxies requests to the user Jenkins.
IMHO that doesn't make sense that service to exist in launcher-backend, since launcher functionality ends after the booster is deployed. We need to move that code somewhere else. What would be the appropriate project to live on?
The text was updated successfully, but these errors were encountered: