CI was here #10
Merged
CI was here #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
… instead of "hard" failing, we could just skip it as it doesn't meet the requirements. Impacted tests : - TestHelmDeployPipelineRun - TestKanikoTaskRun To skip those tests instead of failing, you need to provide the following arguments to go test command : `-ldflags '-X github.com/tektoncd/pipeline/test.missingKoFatal=false'` Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
We should try to avoid, as much as possible, to assume that there will be a docker socket available on the node. If the runtime used by Kubernetes is not Docker, this fails. This affects : TestPipelineRun and private-taskrun and taskrun-docker-basic examples. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arilivigni, matzew, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to do to make CI green :
-ldflags …in the e2e scriptsSigned-off-by: Vincent Demeester vdemeest@redhat.com