Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list_all_resources to reliability tests #799

Merged

Conversation

mehabhalodiya
Copy link
Contributor

Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2024
Copy link

openshift-ci bot commented Nov 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mehabhalodiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@qiliRedHat
Copy link
Contributor

@mehabhalodiya Is this ready for review? You have the work in progress label. Are you still working on adding the script to the reliability config file as a task?

@mehabhalodiya mehabhalodiya marked this pull request as ready for review November 20, 2024 19:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2024
@mehabhalodiya
Copy link
Contributor Author

@qiliRedHat You can help me by reviewing it.

@qiliRedHat
Copy link
Contributor

@mehabhalodiya Please add a task in reliability.yaml to include this script and test it. If you just want to add the script first and add task in another pr, I'm good with it.

@qiliRedHat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1ca4ba8 into openshift:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants