Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 4.18 regress job #60739

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@qiliRedHat qiliRedHat marked this pull request as draft January 17, 2025 09:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@openshift-ci-robot
Copy link
Contributor

@qiliRedHat, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[2].as: 'OCP-43281-router-scale-test' is not a valid Kubernetes object name
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: invalid configuration: tests[2].as: 'OCP-43281-router-scale-test' is not a valid Kubernetes object name
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@qiliRedHat
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-ingress-scale-test

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@qiliRedHat qiliRedHat force-pushed the 418-regression branch 5 times, most recently from 2056eb9 to f711afb Compare January 20, 2025 09:40
@qiliRedHat
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-ingress-scale-test

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@qiliRedHat
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-ingress-scale-test

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@qiliRedHat
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-ingress-scale-test

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@qiliRedHat qiliRedHat marked this pull request as ready for review January 21, 2025 14:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@qiliRedHat
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-ingress-scale-test

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 22, 2025
@qiliRedHat
Copy link
Contributor Author

@paigerube14 PTAL

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 22, 2025
@openshift-ci-robot
Copy link
Contributor

@qiliRedHat, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: duplicated presubmit jobs (consider both inrepo and central config): [pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-regression-scale-affinity-rules pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-regression-scale-loaded-projects]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: duplicated presubmit jobs (consider both inrepo and central config): [pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-regression-scale-affinity-rules pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-regression-scale-loaded-projects]
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@qiliRedHat
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 23, 2025
@qiliRedHat
Copy link
Contributor Author

@paigerube14 PTAL. I addes ES credentials to the step to have ingres-perf in my scripts to run.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@qiliRedHat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-ingress-scale-ocp-43281-ingress-tunning-ocp-43175 openshift/svt presubmit Presubmit changed
pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-networkpolicy-scale-ocp-41535 openshift/svt presubmit Presubmit changed
pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-regression-scale-loaded-projects openshift/svt presubmit Registry content changed
pull-ci-openshift-svt-master-regression-aws-4.17-nightly-x86-regression-scale-loaded-projects openshift/svt presubmit Registry content changed
pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-regression-scale-affinity-rules openshift/svt presubmit Registry content changed
pull-ci-openshift-svt-master-regression-aws-4.17-nightly-x86-regression-scale-affinity-rules openshift/svt presubmit Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 23, 2025
@qiliRedHat
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-svt-master-regression-aws-4.18-nightly-x86-networkpolicy-scale-ocp-41535

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@paigerube14
Copy link
Contributor

@qiliRedHat I'm not sure if we want to index these regression test results into elastic search and I'm not sure if the indexing properly worked

�[1mThu Jan 23 09:26:15 UTC 2025 Indexing benchmark metadata to /ripsaw-kube-burner�[0m
curl: (3) URL using bad/illegal format or missing URL
�[1mThu Jan 23 09:26:15 UTC 2025 benchmark�[0m

@qiliRedHat
Copy link
Contributor Author

qiliRedHat commented Jan 24, 2025

@paigerube14
In the networkpolicy-scale regression test log the data is not indexed to ES because Elastic server is not defined. That's what I expected. Because in this test, the kube-burner is used to just load the custom workerload, I don't want to index anything to ES.

/tmp/svt/perfscale_regression_ci/scripts/network/e2e-benchmarking/workloads/kube-burner
�[1mThu Jan 23 09:23:40 UTC 2025 Indexing benchmark metadata to /ripsaw-kube-burner�[0m
curl: (3) URL using bad/illegal format or missing URL
�[1mThu Jan 23 09:23:40 UTC 2025 benchmark�[0m
Elastic server is not defined, please check

While in the first 2 cases ingresss-scale and ingress-tunning, I want to have the data indexed to ES because the test needs to compare performance from grafana dashboard. To do that I had the ES_SERVER defined in run_ingress_perf() func.
https://github.com/openshift/svt/blob/master/perfscale_regression_ci/utils/run_workload.sh#L36.

If any case need kube-burner to index to ES as well, we can do the same to define ES_SERVER in the test case script.

@paigerube14
Copy link
Contributor

@qiliRedHat makes sense, I just don't think we should get in the habit of pushing data to ES for these test cases. The folder we are using is much older and don't want to be posting incorrect documents that mess up the ES instance

@paigerube14
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2025
Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paigerube14, qiliRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiliRedHat
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@qiliRedHat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 27, 2025
Copy link
Contributor

openshift-ci bot commented Jan 27, 2025

@qiliRedHat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c0faea into openshift:master Jan 27, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants