openshift-os: promote openshift-os-src image
#31973
Conversation
bc2fcf9 to
d7c34be
Compare
| FROM registry.access.redhat.com/ubi9/ubi-minimal | ||
| WORKDIR /src | ||
| # Copy the source code | ||
| COPY . . |
There was a problem hiding this comment.
hm I'm not sure I like the complexity of introducing another image for this, on the other hand having the the os git submodule in okd-machine-os isn't great either. If we go this way, local rebuilds of okd-machine-os will be trickier, as it might not be obvious how the openshift-os-src image is created.
Currently, all of this would be for just the 06gcp-routes overlay. Alternatively we could carry a copy of the gcp-routes overlay that would have to be updated manually (it's 3 files). Maybe there's even a github action to keep dirs/files in sync across repos and create a PR automatically.
There was a problem hiding this comment.
Alternatively we could carry a copy of the gcp-routes overlay that would have to be updated manually (it's 3 files)
Right, that's an option, however more overlays may need to be carried (i.e. dhcp-chrony) and we won't get fixes for those automatically, so I'd prefer to get a copy of these overlays automatically. Submodules is a solution, but a fairly ugly one
There was a problem hiding this comment.
This discussion overlaps some with bits of https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/OPSZ7I4JLFTDC65FPEOUN4CZJNEGKGDS/ - basically, perhaps we should be factoring these systems units into RPMs.
Something like openshift-node-common.rpm or something? Actually if we did this, it would also be a good place to take a stab at some of openshift/machine-config-operator#3137 too.
There was a problem hiding this comment.
(That'd be a nontrivial change, I have no strong opinion on a shorter-term/easier solution of promoting the src container versus submodules etc.)
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
d7c34be to
b066981
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This image contains just the source code of openshift/os, so that okd-machine-os could reuse some overlays, instead of importing openshift-os as a submodule. Other images are not referring to this image, so it would not be included in the payload
b066981 to
cc18db2
Compare
|
/cc @cgwalters |
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@vrutkovs: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This image contains just the source code of openshift/os, so that
okd-machine-os could reuse some overlays, instead of importing
openshift-os as a submodule.
Other images are not referring to this image, so it would not be included
in the payload