Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSD-19887]add replace pull secret for HCP clusters #621

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[OSD-19887]add replace pull secret for HCP clusters #621

merged 1 commit into from
Nov 4, 2024

Conversation

bmeng
Copy link
Contributor

@bmeng bmeng commented Oct 29, 2024

@bmeng bmeng force-pushed the hcp-owner-transfer branch from 1558aa7 to b6591cb Compare October 30, 2024 07:11
devppratik
devppratik reviewed Oct 30, 2024
View reviewed changes
cmd/cluster/transferowner.go Outdated Show resolved Hide resolved
cmd/cluster/transferowner.go Outdated Show resolved Hide resolved
cmd/cluster/transferowner.go Outdated Show resolved Hide resolved
pkg/utils/ocm.go Outdated Show resolved Hide resolved
devppratik
devppratik reviewed Oct 30, 2024
View reviewed changes
pkg/utils/ocm.go Outdated Show resolved Hide resolved
pkg/utils/ocm.go Show resolved Hide resolved
cmd/cluster/transferowner.go Show resolved Hide resolved
samanthajayasinghe
samanthajayasinghe reviewed Oct 30, 2024
View reviewed changes
pkg/utils/ocm.go Outdated Show resolved Hide resolved
cmd/network/verification.go Outdated Show resolved Hide resolved
@bmeng bmeng force-pushed the hcp-owner-transfer branch from b6591cb to 94939d9 Compare November 4, 2024 03:40
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2024
@bmeng bmeng force-pushed the hcp-owner-transfer branch from 94939d9 to 3ef9ae3 Compare November 4, 2024 03:43
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@bmeng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@devppratik
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, devppratik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2ebcf8b into openshift:master Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devppratik devppratik devppratik left review comments

@samanthajayasinghe samanthajayasinghe samanthajayasinghe left review comments

@dustman9000 dustman9000 Awaiting requested review from dustman9000

@fahlmant fahlmant Awaiting requested review from fahlmant

Assignees

@devppratik devppratik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmeng @devppratik @samanthajayasinghe @openshift-merge-robot