-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD-24621 - Add 'cluster ssh key' subcommand to find and print the ssh key for a cluster #599
Conversation
/hold Basics are here, few minor adjustments still needed |
882d1de
to
632e6a9
Compare
/unhold |
a21d6d5
to
d5d4bcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…h key for a given cluster
@tnierman: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm One small suggestion we could implement in a follow-up: we could default to not printing the key to stdout, instead store it to e.g. a tmp file. This could prevent leaks via screenshares. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnierman, typeid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/OSD-24621
Adds subcommand allowing users to quickly retrieve clusters' ssh keys from hive. The key is printed to stdout, allowing it to easily be redirected into files and/or copy/pasted.
If a cluster identifier is provided as a positional argument, then the ssh key for that cluster will be retrieved. Otherwise, the key for the currently logged in cluster will be printed.