Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSD-23212] Cloudtrailmcmd Permission-denied history Feature #575

Merged

Conversation

TomNelsonTembo
Copy link
Contributor

Permission-denied command facilitates in locating permission denied events using Cloudtrail in a customers AWS account. This will enable us to quickly figure out if a permission is missing or blocked by an SCP.

@openshift-ci openshift-ci bot requested review from fahlmant and mjlshen May 28, 2024 20:25
@typeid
Copy link
Member

typeid commented Jun 3, 2024

/assign - I'll take a look at this :)

Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I tested it and it is already fully functional. Left mostly just code structure comments.

cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/pkg/util.go Outdated Show resolved Hide resolved
cmd/cloudtrail/pkg/util.go Outdated Show resolved Hide resolved
cmd/cloudtrail/pkg/util.go Outdated Show resolved Hide resolved
moves test to correct package
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/pkg/aws/aws.go Outdated Show resolved Hide resolved
cmd/cloudtrail/permission-denied.go Outdated Show resolved Hide resolved
cmd/cloudtrail/cloudtrail_test.go Outdated Show resolved Hide resolved
cmd/cloudtrail/pkg/aws/aws.go Outdated Show resolved Hide resolved
cmd/cloudtrail/write-events.go Outdated Show resolved Hide resolved
Copy link
Member

@typeid typeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

/lgtm
/approve

@typeid
Copy link
Member

typeid commented Jun 24, 2024

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 24, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomNelsonTembo, typeid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

@TomNelsonTembo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 03036d0 into openshift:master Jun 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants