jenkins: Make RHCOS AMI Public #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are on the right track, but I think we should be making the AMI public after it passes our |
|
Thanks for the feedback @miabbott ! Will update & repush. |
|
Good catch! |
cgwalters
reviewed
Sep 19, 2018
Jenkinsfile.aws-test
Outdated
| @@ -61,6 +61,9 @@ node(NODE) { | |||
| aws ec2 modify-image-attribute \ | |||
| --image-id ${ami_intermediate} \ | |||
| --launch-permission '{"Add":[{"UserId":"${AWS_CI_ACCOUNT}"}]}' | |||
| aws ec2 modify-image-attribute \ | |||
| --image-id ${ami_intermediate} \ | |||
| --launch-permission "Add=[{Group=all}] | |||
There was a problem hiding this comment.
We can drop the previous invocation of modify-image-attribute since now anyone can access right?
There was a problem hiding this comment.
(Or alternatively think of this as just changing the argument to `--launch-permission)
There was a problem hiding this comment.
Quoting looks a bit off -- I'm guessing it should be '{"Add":[{"Group":"all"}]}' ?
There was a problem hiding this comment.
I agree. I think @jlebon has the right idea on the quoting.
--launch-permission "Add=[{Group=all}]
becomes
--launch-permission '{"Add":[{"Group":"all"}]}'
There was a problem hiding this comment.
We can drop the previous invocation of modify-image-attribute since now anyone can access right?
Yup! We shouldn't need to do that any longer. @kikisdeliveryservice If you don't mind, add another commit in this PR to remove that section.
There was a problem hiding this comment.
Thanks @ashcrow @jlebon @cgwalters ! I'll make those changes and repush.
|
/hold |
|
/hold cancel |
ashcrow
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
Looks good! Will defer to @jlebon, @miabbott, or @cgwalters on merge.
|
/lgtm |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 21, 2018
We're pushing public AMIs since openshift/os@6dd20dc6 (jenkins: Make RHCOS AMI Public, 2018-09-18, openshift/os#304). There's still no public analog to [1], so I'm just scraping this from metadata on images available via the AWS API. The analogous AWS command line invocation is: $ AWS_DEFAULT_REGION=us-east-1 aws ec2 describe-images --filter 'Name=name,Values=rhcos*' --query 'sort_by(Images, &CreationDate)[-1].ImageId' --output text with a few extra filters thrown in. The full set of metadata on the most recent current image is: $ AWS_DEFAULT_REGION=us-east-1 aws ec2 describe-images --filter 'Name=name,Values=rhcos*' --query 'sort_by(Images, &CreationDate)[-1]' --output json { "VirtualizationType": "hvm", "Description": "Red Hat CoreOS 4.0.5846 (c9a6bb48b837b5bcfeb9bd427be9a18b5bd75b6c57cb289245f211ff98b2a740)", "Hypervisor": "xen", "EnaSupport": true, "SriovNetSupport": "simple", "ImageId": "ami-08a5792a684330602", "State": "available", "BlockDeviceMappings": [ { "DeviceName": "/dev/xvda", "Ebs": { "Encrypted": false, "DeleteOnTermination": true, "VolumeType": "gp2", "VolumeSize": 8, "SnapshotId": "snap-00a45db4ad6173805" } }, { "DeviceName": "/dev/xvdb", "VirtualName": "ephemeral0" } ], "Architecture": "x86_64", "ImageLocation": "531415883065/rhcos_dev_c9a6bb4-hvm", "RootDeviceType": "ebs", "OwnerId": "531415883065", "RootDeviceName": "/dev/xvda", "CreationDate": "2018-09-19T23:40:54.000Z", "Public": true, "ImageType": "machine", "Name": "rhcos_dev_c9a6bb4-hvm" } That doesn't include the "tested" information, so there's still no support for changing channels. We'll need to wait for a public analog of [1], which is blocked on getting stable, production hosting for the release metadata. I'd prefer to use JMESPath and server-side filtering in Go as well, to only return the latest matching AMI. But the AWS Go library doesn't seem to support server-side filtering at the moment [2]. Docs for the AWS Go APIs I'm using are in [3,4,5,6,7,8]. The filters I'm adding here are similar to those we used for Container Linux before they were dropped in 702ee7b (*: Remove stale Container Linux references, 2018-09-11, openshift#233). I added a few more just to be conservative (e.g. we don't want to match a pending or failed image, so I require state to be available). I haven't pushed the Context variables all the way up the stack yet, so there are some context.TODO() entries. The 30-second timeout keeps us from hanging excessively when the caller lacks AWS credentials; the error messages look like: failed to init cluster: failed to parse test config: failed to determine default AMI: NoCredentialProviders: no valid providers in chain. Deprecated. For verbose messaging see aws.Config.CredentialsChainVerboseErrors You can test this error condition by removing the explicit AMI values I've added to our fixtures in this commit and running: $ AWS_PROFILE=does-not-exist go test ./installer/pkg/... [1]: http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/aws-us-east-1-tested.json [2]: aws/aws-sdk-go#2156 [3]: https://docs.aws.amazon.com/sdk-for-go/api/aws/session/#NewSessionWithOptions [4]: https://docs.aws.amazon.com/sdk-for-go/api/aws/session/#Options [5]: https://docs.aws.amazon.com/sdk-for-go/api/aws/session/#Must [6]: https://docs.aws.amazon.com/sdk-for-go/api/service/ec2/#New [7]: https://docs.aws.amazon.com/sdk-for-go/api/service/ec2/#EC2.DescribeImagesWithContext [8]: https://docs.aws.amazon.com/sdk-for-go/api/service/ec2/#DescribeImagesInput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first PR, so I'm a bit unsure about the format of the PR, etc... If you have any feedback let me know! :)