OCPBUGS-2926: platforms: add secondary serial console on OpenStack/VirtualBox/VMware #1044

bgilbert · 2022-10-28T08:06:31Z

Previously, openstack console log <server> was useful for collecting console logs from OpenStack VMs, and the serial console was similarly useful in VMware, but we disabled serial console output on both platforms. Re-enable it as a secondary console so it gets as much information as possible without interfering with the graphical console. Do the same on VirtualBox to stay in sync with FCOS.

Fixes: https://issues.redhat.com/browse/OCPBUGS-2926
xref: coreos/fedora-coreos-config#2038

travier · 2022-10-28T08:29:55Z

/lgtm

travier · 2022-10-28T08:30:48Z

/hold
We'll merge that right after the FCOS changes land.

travier · 2022-10-28T08:54:34Z

/test rhcos-86-build-test-metal

EmilienM · 2022-10-28T13:31:46Z

Thanks @bgilbert ! This looks good to me but I'll ping a few other folks to confirm from the OpenStack side:
@stephenfin @mdbooth

travier · 2022-10-28T13:38:43Z

/test scos-9-build-test-qemu

bgilbert · 2022-10-28T21:10:04Z

/retest

The Fedora CoreOS version merged. It'd be nice to get some OpenStack testing here though.

mdbooth · 2022-10-31T17:05:19Z

/retest

The Fedora CoreOS version merged. It'd be nice to get some OpenStack testing here though.

I'll do my best. How can I test this?

Previously, `openstack console log <server>` was useful for collecting console logs from OpenStack VMs, and the serial console was similarly useful in VMware, but we disabled serial console output on both platforms. Re-enable it as a secondary console so it gets as much information as possible without interfering with the graphical console. Do the same on VirtualBox to stay in sync with FCOS. Fixes: https://issues.redhat.com/browse/OCPBUGS-2926 xref: coreos/fedora-coreos-config#2038

bgilbert · 2022-10-31T18:47:30Z

@mdbooth Thanks! I'll send you an OpenStack image with the change.

mdbooth · 2022-10-31T19:48:35Z

@bgilbert New image fixes console log on OpenStack. Thanks!

/lgtm

openshift-ci · 2022-10-31T19:49:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgilbert, mdbooth, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bgilbert,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bgilbert · 2022-10-31T20:19:22Z

Great, thanks for testing!

Lifting hold from #1044 (comment) since the FCOS changes have landed.

openshift-ci-robot · 2022-10-31T20:20:25Z

@bgilbert: This pull request references Jira Issue OCPBUGS-2926, which is invalid:

expected the bug to target the "4.13.0" version, but it targets "4.12.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Previously, openstack console log <server> was useful for collecting console logs from OpenStack VMs, and the serial console was similarly useful in VMware, but we disabled serial console output on both platforms. Re-enable it as a secondary console so it gets as much information as possible without interfering with the graphical console. Do the same on VirtualBox to stay in sync with FCOS.

Untested on OpenStack.

Fixes: https://issues.redhat.com/browse/OCPBUGS-2926
xref: coreos/fedora-coreos-config#2038

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bgilbert · 2022-10-31T20:23:50Z

/hold cancel
/jira refresh

openshift-ci-robot · 2022-10-31T20:23:56Z

@bgilbert: This pull request references Jira Issue OCPBUGS-2926, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.0) matches configured target version for branch (4.13.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/hold cancel
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bgilbert · 2022-10-31T20:59:37Z

/retest

bgilbert · 2022-10-31T23:54:47Z

/retest

bgilbert · 2022-11-01T02:59:41Z

/retest

mike-nguyen · 2022-11-01T11:42:23Z

/retest

mdbooth · 2022-11-01T15:17:16Z

/retest-required

platforms.yaml

bgilbert · 2022-11-02T16:13:38Z

The scos-9-build-test-qemu failures are coreos/fedora-coreos-tracker#1325.

/override ci/prow/scos-9-build-test-qemu

openshift-ci · 2022-11-02T16:14:16Z

@bgilbert: Overrode contexts on behalf of bgilbert: ci/prow/scos-9-build-test-qemu

In response to this:

The scos-9-build-test-qemu failures are coreos/fedora-coreos-tracker#1325.

/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-02T16:14:19Z

@bgilbert: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2022-11-02T16:17:04Z

@bgilbert: All pull requests linked via external trackers have merged:

openshift/os#1044

Jira Issue OCPBUGS-2926 has been moved to the MODIFIED state.

In response to this:

Previously, openstack console log <server> was useful for collecting console logs from OpenStack VMs, and the serial console was similarly useful in VMware, but we disabled serial console output on both platforms. Re-enable it as a secondary console so it gets as much information as possible without interfering with the graphical console. Do the same on VirtualBox to stay in sync with FCOS.

Untested on OpenStack.

Fixes: https://issues.redhat.com/browse/OCPBUGS-2926
xref: coreos/fedora-coreos-config#2038

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-11-02T16:19:44Z

@bgilbert: Jira Issue OCPBUGS-2926 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Previously, openstack console log <server> was useful for collecting console logs from OpenStack VMs, and the serial console was similarly useful in VMware, but we disabled serial console output on both platforms. Re-enable it as a secondary console so it gets as much information as possible without interfering with the graphical console. Do the same on VirtualBox to stay in sync with FCOS.

Fixes: https://issues.redhat.com/browse/OCPBUGS-2926
xref: coreos/fedora-coreos-config#2038

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bgilbert · 2022-11-02T17:06:16Z

/cherrypick release-4.12

openshift-cherrypick-robot · 2022-11-02T17:06:56Z

@bgilbert: new pull request created: #1051

In response to this:

/cherrypick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from c4rt0 and cgwalters October 28, 2022 08:07

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2022

openshift-ci bot assigned travier Oct 28, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2022

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2022

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2022

openshift-ci bot assigned mdbooth Oct 31, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2022

bgilbert changed the title ~~platforms: add secondary serial console on OpenStack/VirtualBox/VMware~~ OCPBUGS-2926: platforms: add secondary serial console on OpenStack/VirtualBox/VMware Oct 31, 2022

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 31, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2022

openshift-ci bot requested a review from mike-nguyen October 31, 2022 20:23

SeanMooney reviewed Nov 1, 2022

View reviewed changes

platforms.yaml Show resolved Hide resolved

openshift-merge-robot merged commit 1615c3e into openshift:master Nov 2, 2022

bgilbert deleted the console branch November 2, 2022 16:19

openshift-cherrypick-robot mentioned this pull request Nov 2, 2022

[release-4.12] OCPBUGS-2995: platforms: add secondary serial console on OpenStack/VirtualBox/VMware #1051

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-2926: platforms: add secondary serial console on OpenStack/VirtualBox/VMware #1044

OCPBUGS-2926: platforms: add secondary serial console on OpenStack/VirtualBox/VMware #1044

bgilbert commented Oct 28, 2022 •

edited

Loading

travier commented Oct 28, 2022

travier commented Oct 28, 2022

travier commented Oct 28, 2022

EmilienM commented Oct 28, 2022

travier commented Oct 28, 2022

bgilbert commented Oct 28, 2022

mdbooth commented Oct 31, 2022

bgilbert commented Oct 31, 2022

mdbooth commented Oct 31, 2022

openshift-ci bot commented Oct 31, 2022

bgilbert commented Oct 31, 2022 •

edited

Loading

openshift-ci-robot commented Oct 31, 2022

bgilbert commented Oct 31, 2022

openshift-ci-robot commented Oct 31, 2022

bgilbert commented Oct 31, 2022

bgilbert commented Oct 31, 2022

bgilbert commented Nov 1, 2022

mike-nguyen commented Nov 1, 2022

mdbooth commented Nov 1, 2022

bgilbert commented Nov 2, 2022

openshift-ci bot commented Nov 2, 2022

openshift-ci bot commented Nov 2, 2022

openshift-ci-robot commented Nov 2, 2022

openshift-ci-robot commented Nov 2, 2022

bgilbert commented Nov 2, 2022

openshift-cherrypick-robot commented Nov 2, 2022

OCPBUGS-2926: platforms: add secondary serial console on OpenStack/VirtualBox/VMware #1044

OCPBUGS-2926: platforms: add secondary serial console on OpenStack/VirtualBox/VMware #1044

Conversation

bgilbert commented Oct 28, 2022 • edited Loading

travier commented Oct 28, 2022

travier commented Oct 28, 2022

travier commented Oct 28, 2022

EmilienM commented Oct 28, 2022

travier commented Oct 28, 2022

bgilbert commented Oct 28, 2022

mdbooth commented Oct 31, 2022

bgilbert commented Oct 31, 2022

mdbooth commented Oct 31, 2022

openshift-ci bot commented Oct 31, 2022

bgilbert commented Oct 31, 2022 • edited Loading

openshift-ci-robot commented Oct 31, 2022

bgilbert commented Oct 31, 2022

openshift-ci-robot commented Oct 31, 2022

bgilbert commented Oct 31, 2022

bgilbert commented Oct 31, 2022

bgilbert commented Nov 1, 2022

mike-nguyen commented Nov 1, 2022

mdbooth commented Nov 1, 2022

bgilbert commented Nov 2, 2022

openshift-ci bot commented Nov 2, 2022

openshift-ci bot commented Nov 2, 2022

openshift-ci-robot commented Nov 2, 2022

openshift-ci-robot commented Nov 2, 2022

bgilbert commented Nov 2, 2022

openshift-cherrypick-robot commented Nov 2, 2022

bgilbert commented Oct 28, 2022 •

edited

Loading

bgilbert commented Oct 31, 2022 •

edited

Loading