Add deployment Conditions and oc rollout status #9874

0xmichalis · 2016-07-15T12:03:07Z

Fixes #10994
Trello card: https://trello.com/c/OIggCmzo/699-5-deployments-downstream-conditions

fabianofranz · 2016-07-20T17:50:42Z

pkg/cmd/cli/cmd/rollout/rollout.go

+
+const (
+	rolloutStatusLong = `
+Watch the status of the latest rollout, until it's done.`


Meaning the command waits and blocks and only exit when the rollout is completed? In such case I'd vote for oc rollout watch or oc rollout status --watch (exits right away without the flag) for consistency.

This proposal needs to move upstream

On Wed, Jul 20, 2016 at 7:50 PM, Fabiano Franz notifications@github.com
wrote:

In pkg/cmd/cli/cmd/rollout/rollout.go
#9874 (comment):

@@ -134,3 +135,20 @@ func NewCmdRolloutUndo(fullName string, f *clientcmd.Factory, out io.Writer) *co
cmd.Example = fmt.Sprintf(rolloutUndoExample, fullName)
return cmd
}
+
+const (

rolloutStatusLong = +Watch the status of the latest rollout, until it's done.

Meaning the command waits and blocks and only exit when the rollout is
completed? In such case I'd vote for oc rollout watch or oc rollout
status --watch (exits right away without the flag) for consistency.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openshift/origin/pull/9874/files/7384f4c3e74a711cdb73ecb1d1958c1b3dc6f251#r71573627,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADuFf3RedOQQ1cZeVl6Rb8Otb6xPqxmrks5qXl_3gaJpZM4JNVe5
.

Opened kubernetes/kubernetes#30627

kubernetes/kubernetes#34106

0xmichalis · 2016-08-16T12:44:07Z

There is an issue here: kubectl rollout status will watch for events on the provided resource.

deployment/foo: A deployment is considered complete once foo.spec.replicas == foo.status.updatedReplicas

dc/foo: A deployment is considered complete once openshift.io/deployment-phase=Complete is added in the underlying replication controller.

This issue screams for Conditions in the deployment config. The DC controller should update a DC that was successfully deployed with a Condition, oc rollout status (and every other client for that matter) should expect such a Condition before exiting.

smarterclayton · 2016-08-16T16:41:13Z

Yes.

On Tue, Aug 16, 2016 at 8:44 AM, Michail Kargakis notifications@github.com
wrote:

There is an issue here: kubectl rollout status will watch for events on
the provided resource.

deployment/foo: A deployment is considered complete once foo.spec.replicas
== foo.status.updatedReplicas

dc/foo: A deployment is considered complete once
openshift.io/deployment-phase=Complete is added in the underlying
replication controller.

This issue screams for Conditions in the deployment config. The DC
controller should update a DC that was successfully deployed with a
Condition, oc rollout status (and every other client for that matter)
should expect such a Condition before exiting.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9874 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_p5zL3KJOw-cY2ih5CROcz-YB6qoTks5qgbCZgaJpZM4JNVe5
.

0xmichalis · 2016-09-05T15:42:44Z

Blocked for now. Will handle as part of https://trello.com/c/OIggCmzo/699-5-deployments-downstream-conditions

0xmichalis · 2016-10-03T11:03:14Z

Added conditions alongside rollout status, needs reviews

mfojtik · 2016-10-05T12:11:45Z

pkg/cmd/cli/cmd/rollout/rollout.go

+	rolloutStatusLong = `
+Watch the status of the latest rollout, until it's done.`
+
+	rolloutStatusExample = `  # Watch the status of the latest rollout


this wont watch when the rollout is complete, just print the status, right?

It watches until the end of the rollout. @fabianofranz asked for a --watch flag that we will default to true to make it clearer: kubernetes/kubernetes#30627

mfojtik · 2016-10-05T12:13:01Z

pkg/deploy/cmd/status.go

+		case deployutil.HasImageChangeTrigger(config):
+			return fmt.Sprintf("Deployment config %q waiting on image update", name), false, nil
+		case len(config.Spec.Triggers) == 0:
+			return fmt.Sprintf("Deployment config %q waiting on manual update (use 'oc deploy %s --latest')", name, name), true, nil


this will be oc rollout latest right?

Yes, will update

mfojtik · 2016-10-05T12:13:50Z

pkg/deploy/cmd/status.go

+			// Return as an error.
+			return fmt.Sprintf("%s\n", cond.Message), true, errors.New(cond.Message)
+		case cond != nil && cond.Reason == deployutil.PausedDeployReason:
+			return fmt.Sprintf("Deployment config %q is paused. Unpause to continue watching the status of the rollout.\n", config.Name), true, nil


s/Unpause/Resume/

mfojtik · 2016-10-10T13:17:16Z

LGTM [merge]

openshift-bot · 2016-10-10T13:22:25Z

[Test]ing while waiting on the merge queue

0xmichalis · 2016-10-10T16:00:08Z

#11292 and #11240 [merge]

0xmichalis · 2016-10-10T16:32:16Z

#10773 [test]

0xmichalis · 2016-10-11T08:46:04Z

#11240 [test]

openshift-bot · 2016-10-11T08:47:33Z

Evaluated for origin test up to 3417ff0

openshift-bot · 2016-10-11T11:08:11Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9867/)

0xmichalis · 2016-10-13T09:49:12Z

#11353 [merge]

0xmichalis · 2016-10-13T12:01:45Z

#11074 [merge]

openshift-bot · 2016-10-13T12:02:34Z

Evaluated for origin merge up to 3417ff0

openshift-bot · 2016-10-13T13:32:39Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10009/) (Base Commit: 50cc896) (Image: devenv-rhel7_5171)

0xmichalis assigned fabianofranz Jul 18, 2016

fabianofranz reviewed Jul 20, 2016
View reviewed changes

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 13, 2016

danmcp added the priority/P2 label Aug 31, 2016

0xmichalis added the blocked label Sep 5, 2016

0xmichalis mentioned this pull request Sep 9, 2016

oc deploy --latest can't wait for the deployment and return correct exist status #10864

Closed

openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2016

0xmichalis mentioned this pull request Sep 19, 2016

'oc rollout status' is missing #10994

Closed

kadel mentioned this pull request Sep 21, 2016

oc deploy jobs should wait for deployment to finish openshiftio/openshiftio-cico-jobs#7

Closed

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2016

0xmichalis removed the blocked label Oct 3, 2016

0xmichalis assigned mfojtik Oct 3, 2016

0xmichalis added the api-approved label Oct 3, 2016

0xmichalis changed the title ~~oc: add rollout status~~ Add deployment Conditions and oc rollout status Oct 3, 2016

0xmichalis mentioned this pull request Oct 3, 2016

[WIP] Deployment conditions #11056

Closed

0xmichalis added this to the 1.4.0 milestone Oct 3, 2016

0xmichalis mentioned this pull request Oct 4, 2016

Deployment conditions api #11214

Merged

mfojtik suggested changes Oct 5, 2016

View reviewed changes

openshift-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 5, 2016

0xmichalis added 3 commits October 10, 2016 11:05

deploy: use Conditions in the deploymentconfig controller

48a4dbf

oc: add rollout status

0575a2c

oc: generated code for rollout status

9d3d249

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2016

0xmichalis added 2 commits October 10, 2016 17:00

Tests for deployment conditions and oc rollout status

18495da

UPSTREAM: <drop>: rollout status should return appropriate exit codes

3417ff0

openshift-bot merged commit 6b0457c into openshift:master Oct 13, 2016

0xmichalis deleted the rollout-status branch October 13, 2016 14:56

juanvallejo mentioned this pull request Oct 13, 2016

'oc rollout status' will return exit code 0 even though the command status does not exist #11043

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add deployment Conditions and oc rollout status #9874

Add deployment Conditions and oc rollout status #9874

0xmichalis commented Jul 15, 2016 •

edited

Loading

fabianofranz Jul 20, 2016

0xmichalis Jul 20, 2016

0xmichalis Aug 15, 2016

0xmichalis Oct 5, 2016

0xmichalis commented Aug 16, 2016

smarterclayton commented Aug 16, 2016

0xmichalis commented Sep 5, 2016

0xmichalis commented Oct 3, 2016

mfojtik Oct 5, 2016

0xmichalis Oct 5, 2016

mfojtik Oct 5, 2016

0xmichalis Oct 5, 2016

mfojtik Oct 5, 2016

0xmichalis Oct 5, 2016

mfojtik commented Oct 10, 2016

openshift-bot commented Oct 10, 2016

0xmichalis commented Oct 10, 2016

0xmichalis commented Oct 10, 2016

0xmichalis commented Oct 11, 2016

openshift-bot commented Oct 11, 2016

openshift-bot commented Oct 11, 2016

0xmichalis commented Oct 13, 2016

0xmichalis commented Oct 13, 2016

openshift-bot commented Oct 13, 2016

openshift-bot commented Oct 13, 2016 •

edited

Loading

Add deployment Conditions and oc rollout status #9874

Add deployment Conditions and oc rollout status #9874

Conversation

0xmichalis commented Jul 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xmichalis commented Aug 16, 2016

smarterclayton commented Aug 16, 2016

0xmichalis commented Sep 5, 2016

0xmichalis commented Oct 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mfojtik commented Oct 10, 2016

openshift-bot commented Oct 10, 2016

0xmichalis commented Oct 10, 2016

0xmichalis commented Oct 10, 2016

0xmichalis commented Oct 11, 2016

openshift-bot commented Oct 11, 2016

openshift-bot commented Oct 11, 2016

0xmichalis commented Oct 13, 2016

0xmichalis commented Oct 13, 2016

openshift-bot commented Oct 13, 2016

openshift-bot commented Oct 13, 2016 • edited Loading

0xmichalis commented Jul 15, 2016 •

edited

Loading

openshift-bot commented Oct 13, 2016 •

edited

Loading