Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRT-1286: List images from external binaries #29450

Merged
merged 5 commits into from
Feb 19, 2025
Merged

TRT-1286: List images from external binaries #29450

merged 5 commits into from
Feb 19, 2025
+193 −42

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Jan 17, 2025 •
edited
Loading

I recommend to review commits sequentially.

This depends on openshift/kubernetes#2177.

/hold

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

@bertinatto: This pull request references TRT-1286 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning January 17, 2025 20:13
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2025
@bertinatto bertinatto force-pushed the list-images-external-test-binary branch from f00f784 to 4394648 Compare January 18, 2025 00:24
@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Jan 18, 2025

Job Failure Risk Analysis for sha: 4394648

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial Medium
[sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial]
This test has passed 97.10% of 241 runs on release 4.19 [Overall] in the last week.
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium
[sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial]
This test has passed 97.10% of 241 runs on release 4.19 [Overall] in the last week.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2025
@bertinatto bertinatto marked this pull request as draft February 5, 2025 19:02
@bertinatto bertinatto force-pushed the list-images-external-test-binary branch from 4394648 to 1140ca4 Compare February 5, 2025 19:02
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2025
@openshift-ci openshift-ci bot added e2e-images-update Related to images used by e2e tests vendor-update Touching vendor dir or related files labels Feb 5, 2025
@bertinatto
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm openshift/kubernetes#2177

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d87f8230-e401-11ef-9a80-1d64bbfebd29-0

@openshift-ci openshift-ci bot mentioned this pull request Feb 5, 2025
Merged
@bertinatto bertinatto marked this pull request as ready for review February 7, 2025 17:41
@bertinatto bertinatto force-pushed the list-images-external-test-binary branch from 1140ca4 to 6aa62a2 Compare February 7, 2025 17:42
@bertinatto
Copy link
Member Author

/test all

@openshift-ci openshift-ci bot requested review from deads2k and Elbehery February 7, 2025 17:46
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm openshift/kubernetes#2177

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c5d1f2d0-e5a5-11ef-9092-68526eb2380b-0

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Feb 8, 2025

Job Failure Risk Analysis for sha: a3b8d94

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-kube-apiserver-rollout IncompleteTests
Tests for this run (102) are below the historical average (1408): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (17) are below the historical average (2636): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn IncompleteTests
Tests for this run (102) are below the historical average (2436): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

bertinatto
bertinatto commented Feb 10, 2025
View reviewed changes
@bertinatto bertinatto force-pushed the list-images-external-test-binary branch 2 times, most recently from 45e2ff5 to 9b540b4 Compare February 11, 2025 18:10
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@bertinatto: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@bertinatto
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm openshift/kubernetes#2148

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4eb13b00-ed27-11ef-995d-19bee6f30104-0

@openshift-ci openshift-ci bot mentioned this pull request Feb 17, 2025
Draft
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2025
@bertinatto
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm openshift/kubernetes#2209

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d9306070-ed69-11ef-9787-eeb05c04a09d-0

@openshift-ci openshift-ci bot mentioned this pull request Feb 17, 2025
Merged
@bertinatto
Copy link
Member Author

/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm openshift/kubernetes#2209

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/191e30d0-ee2e-11ef-9d09-5fe5cb890333-0

@bertinatto bertinatto force-pushed the list-images-external-test-binary branch from fdcb614 to 46c9bf4 Compare February 19, 2025 12:09
@bertinatto
Copy link
Member Author

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

* periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/191e30d0-ee2e-11ef-9d09-5fe5cb890333-0

This is a green metal job where the release payload was created from this PR, along with a kube bump PR that introduces new test images. This same job fails when the release payload doesn't contain the changes from this PR.

At this point, I have green jobs for multiple PRs tested with this one. Additionally, I have a green CI blocking set and a green nightly blocking set (except for GCP, which was already failing in regular nightlies).

@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bertinatto,stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member Author

/label acknowledge-critical-fixes-only

This fixes a longstanding bug that was first introduced when we started running tests from the k8s-tests external binary.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 19, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node-upgrade 46c9bf4 link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a08c0e0 into openshift:master Feb 19, 2025
30 of 31 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202502192300.p0.ga08c0e0.assembly.stream.el9.
All builds following this will include this PR.

This was referenced Feb 26, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam stbenjam left review comments

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

@sjenning sjenning Awaiting requested review from sjenning

@deads2k deads2k Awaiting requested review from deads2k

@Elbehery Elbehery Awaiting requested review from Elbehery

Assignees

@stbenjam stbenjam

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. e2e-images-update Related to images used by e2e tests jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bertinatto @openshift-ci-robot @stbenjam @openshift-bot @openshift-merge-robot