Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 59170: Fix kubelet PVC stale metrics #18637

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

jsafrane
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 16, 2018
@jsafrane
Copy link
Contributor Author

/assign @derekwaynecarr

@openshift-merge-robot openshift-merge-robot added the vendor-update Touching vendor dir or related files label Feb 16, 2018
@jsafrane
Copy link
Contributor Author

/retest

2 similar comments
@jsafrane
Copy link
Contributor Author

/retest

@jsafrane
Copy link
Contributor Author

/retest

@childsb
Copy link
Contributor

childsb commented Feb 20, 2018

/approve

@mfojtik
Copy link
Contributor

mfojtik commented Feb 28, 2018

/approve

@smarterclayton I think this will have to cherry-pick to release-3.9 right? and we should hold till the branch cut is complete?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2018
@jsafrane jsafrane added this to the 3.9.0 milestone Feb 28, 2018
@jsafrane
Copy link
Contributor Author

/cherrypick release-3.9

If the PR lands after the release is cut, ensure developers apply /cherrypick release-3.9 comment to ensure a new PR is opened against origin/release-3.9.

let's see how this works...

@openshift-cherrypick-robot

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-3.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.9

If the PR lands after the release is cut, ensure developers apply /cherrypick release-3.9 comment to ensure a new PR is opened against origin/release-3.9.

let's see how this works...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tsmetana
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, jsafrane, mfojtik, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Contributor Author

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 1, 2018

/retest

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 1, 2018

/test extended_conformance_install
/test unit
/test extended_networking_minimal
/test gcp

@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 1, 2018

/retest

1 similar comment
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 1, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18745, 18637).

@openshift-merge-robot openshift-merge-robot merged commit 47ae0e5 into openshift:master Mar 1, 2018
@openshift-cherrypick-robot

@jsafrane: new pull request created: #18787

In response to this:

/cherrypick release-3.9

If the PR lands after the release is cut, ensure developers apply /cherrypick release-3.9 comment to ensure a new PR is opened against origin/release-3.9.

let's see how this works...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2018

@jsafrane: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/gcp eba5a49 link /test gcp

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot added a commit that referenced this pull request Mar 3, 2018
…-18637-to-release-3.9

Automatic merge from submit-queue.

[release-3.9] UPSTREAM: 59170: Fix kubelet PVC stale metrics

This is an automated cherry-pick of #18637

/assign jsafrane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants