Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable oc run --attach tests #18577

Closed
wants to merge 1 commit into from
Closed

Re-enable oc run --attach tests #18577

wants to merge 1 commit into from

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 12, 2018

Fixes #11240

This goes in line with #18438, same situation, same problems.

/assign @stevekuznetsov
/assign @smarterclayton

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2018
@stevekuznetsov
Copy link
Contributor

/retest
/lgtm

This should work fine now since we have vendored the lib and are not using journald?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2018
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@stevekuznetsov
Copy link
Contributor

@soltysh looks bad?

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2018
@soltysh
Copy link
Contributor Author

soltysh commented Feb 16, 2018

@soltysh looks bad?

Yeah, will need to check it out.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2018
@soltysh
Copy link
Contributor Author

soltysh commented Feb 16, 2018

I needed to change the invocation in the oc run commands, since there's no cli subcommand anymore, so I needed to call oc explicitly. Should be good now.

@soltysh
Copy link
Contributor Author

soltysh commented Feb 16, 2018

I think it's worth waiting for openshift/release#597 to merge.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2018
@soltysh
Copy link
Contributor Author

soltysh commented May 18, 2018

/remove-lifecycle stale
/lifecycle frozen
/assign

@openshift-ci-robot openshift-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2018
@openshift-ci-robot openshift-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label May 18, 2018
@openshift-bot
Copy link
Contributor

/test cross

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 12, 2018
@soltysh soltysh removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Oct 12, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2018
@soltysh
Copy link
Contributor Author

soltysh commented Oct 12, 2018

I've rebased it, let's see where we are with it.

@soltysh
Copy link
Contributor Author

soltysh commented Oct 15, 2018

@damemi which part of this you're dropping, if this stays ptal otherwise I'll close this.

@soltysh
Copy link
Contributor Author

soltysh commented Oct 15, 2018

/assign @damemi

@openshift-ci-robot
Copy link

@soltysh: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/launch-aws fe138af link /test launch-aws
ci/prow/e2e-aws-serial fe138af link /test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Contributor Author

soltysh commented Feb 12, 2019

Not needed anymore.

@soltysh soltysh closed this Feb 12, 2019
@soltysh soltysh deleted the issue11240 branch February 12, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

@smarterclayton smarterclayton

@damemi damemi

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@soltysh @stevekuznetsov @openshift-bot @openshift-ci-robot @smarterclayton @damemi