UPSTREAM: google.golang.org/grpc: 1005: fix logical race in flow control

[mfojtik]

No description provided.

[enj]

@mfojtik you have an extra zero in the PR number: grpc/grpc-go#1005

[mfojtik]

@enj thanks, fixed.

[mfojtik]

/cherrypick release-3.6
/cherrypick release-3.8

[openshift-cherrypick-robot]

@mfojtik: once the present PR merges, I will cherry-pick it on top of release-3.6
in a new PR and assign it to you.

In response to this:

/cherrypick release-3.6
/cherrypick release-3.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mfojtik]

/cherrypick release-3.8

@Kargakis does the bot don't recognize multiple cherrypick comments?

[openshift-cherrypick-robot]

@mfojtik: once the present PR merges, I will cherry-pick it on top of release-3.8
in a new PR and assign it to you.

In response to this:

/cherrypick release-3.8

@Kargakis does the bot don't recognize multiple cherrypick comments?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

lgtm

[mfojtik]

/retest

[mfojtik]

/retest

[mfojtik]

@smarterclayton do we need/want this?

[tnozicka]

/retest

[smarterclayton]

Yes, I expect us to deliver this to 3.7. Have we had reproducer yet? It’s still happening on west-1

[soltysh]

Yes, I expect us to deliver this to 3.7. Have we had reproducer yet? It’s still happening on west-1

No luck on the reproducer, I've tried several different approaches with this tweaking numbers in many different directions and was never able to reproduce it :/

[smarterclayton]

One way may be to add a print statement to the connect function that shows the current quota number and verify if your test suite can cause the race to happen. Also run with stress -c 8 or whatever in the background. us-west-1 is still hitting this. This is p0

…

On Wed, Dec 20, 2017 at 8:07 AM, Maciej Szulik ***@***.***> wrote: Yes, I expect us to deliver this to 3.7. Have we had reproducer yet? It’s still happening on west-1 No luck on the reproducer, I've tried several different approaches with this <https://github.com/soltysh/origin-tester/blob/master/cmd/tester/main.go> tweaking numbers in many different directions and was never able to reproduce it :/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17735 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p5rx9xsRP_uAecM6Tiq66e_Karm-ks5tCQargaJpZM4Q_gq1> .

[mfojtik]

/retest

@smarterclayton if we can't reliably reproduce this in isolated environment, can we ship this and see if it helps? I'm 85% sure the queue is causing the API server being stuck and the tests in CI for this PR did not revealed any regression AFAIK.

[mfojtik]

@smarterclayton @derekwaynecarr merge?

[mfojtik]

@smarterclayton this should be automatically cherry-picked for 3.8... if not, it means we already have this fix and the grpc bumped.

[soltysh]

Or the alternative #18071?

[soltysh]

Discussed this with @mfojtik and @smarterclayton we're going with this
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• OWNERS [mfojtik]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[smarterclayton]

/retest

…

On Tue, Jan 23, 2018 at 8:26 PM, OpenShift CI Robot < ***@***.***> wrote: @mfojtik <https://github.com/mfojtik>: The following tests *failed*, say /retest to rerun them all: Test name Commit Details Rerun command ci/openshift-jenkins/cmd 1b84e0b <1b84e0b> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17735/test_pull_request_origin_cmd/9111/> /test cmd ci/openshift-jenkins/extended_conformance_install 1b84e0b <1b84e0b> link <https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/17735/test_pull_request_origin_extended_conformance_install/6214/> /test extended_conformance_install Full PR test history <https://openshift-gce-devel.appspot.com/pr/17735>. Your PR dashboard <https://openshift-gce-devel.appspot.com/pr/mfojtik>. Please help us cut down on flakes by linking to <https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests> an open issue <https://github.com/openshift/origin/issues?q=is:issue+is:open> when you hit one in your PR. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/devel/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17735 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p-urT7hS2uGntG9WwkH7R7M6BT94ks5tNoaugaJpZM4Q_gq1> .

[soltysh]

/retest

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[openshift-merge-robot]

Automatic merge from submit-queue.

[openshift-cherrypick-robot]

@openshift-merge-robot: new pull request created: #18270

In response to this:

Automatic merge from submit-queue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@openshift-merge-robot: #17735 failed to apply on top of branch "release-3.8":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	vendor/google.golang.org/grpc/transport/control.go
M	vendor/google.golang.org/grpc/transport/http2_client.go
M	vendor/google.golang.org/grpc/transport/http2_server.go
Falling back to patching base and 3-way merge...
Auto-merging vendor/google.golang.org/grpc/transport/http2_client.go
CONFLICT (content): Merge conflict in vendor/google.golang.org/grpc/transport/http2_client.go
Patch failed at 0001 UPSTREAM: google.golang.org/grpc: 1005: fix logical race in flow control

In response to this:

Automatic merge from submit-queue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.