Backport logs with attach #12648
Backport logs with attach #12648
Conversation
This is docker/docker PR 26718 because docker has reintegrated engine-api into the primary docker repo.
|
I haven't touched any tests yet. Let me know what needs changing since things have evolved since I was last in there. |
|
[test] |
|
I believe @soltysh added set +e around the failing tests |
|
in test/end-to-end/core.sh |
|
Evaluated for origin test up to a93931b |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13248/) (Base Commit: c5868ac) |
|
I think just revert 5696d6d |
|
If the problem persists, and from what I've seen it's still there I'll look into that bug more. Otherwise this LGTM, except for that change Clayton asked for. |
|
Talked to @soltysh on irc. We're going to merge this as-is, but keep the changes to the tests that allow the in-cluster configuration tests to fail without erroring. We'll let jenkins run tests for a few days and then check to see if this PR has resolved the issue or if it's still happening. |
|
[merge] |
|
Evaluated for origin merge up to a93931b |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13302/) (Base Commit: f762dc6) (Image: devenv-rhel7_5776) |
@smarterclayton @mfojtik @soltysh @liggitt xref #11240 #12558