Add additional warning for oc cluster up not being able to access port 8443 #11597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csrwng
reviewed
Oct 27, 2016
| @@ -372,7 +372,7 @@ func (h *Helper) Start(opt *StartOptions, out io.Writer) (string, error) { | |||
| fmt.Fprintf(out, "Waiting for API server to start listening\n") | |||
| masterHost := fmt.Sprintf("%s:8443", opt.ServerIP) | |||
| if err = cmdutil.WaitForSuccessfulDial(true, "tcp", masterHost, 200*time.Millisecond, 1*time.Second, serverUpTimeout); err != nil { | |||
| return "", ErrTimedOutWaitingForStart(h.containerName).WithDetails(h.OriginLog()) | |||
| return "", errors.NewError("timed out waiting for OpenShift container %q \nWARNING: %s:8443 may be blocked by firewall rules", h.containerName, opt.ServerIP).WithDetails(h.OriginLog()) | |||
There was a problem hiding this comment.
I would add something to the effect of
.WithSolution("Ensure that you can access %s from your machine", masterHost)
|
test failure was due to #11560 |
…rules on oc cluster up Fixes issue #10807
|
[test] |
|
Evaluated for origin test up to 8c99bd5 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10733/) (Base Commit: 7366167) |
|
LGTM, @bparees ptal |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10733/) (Image: devenv-rhel7_5263) |
|
Evaluated for origin merge up to 8c99bd5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding warning about port 8443 potentially being blocked by firewall rules on oc cluster up
Fixes issue #10807