Clarify how we handle compression as a router env #11485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JacobTanenbaum @ramr PTAL |
|
LGTM |
|
[test] |
This just cleans up how we handle compression support in the haproxy config to make it more like the existing code. There is no functional change.
318833b to
b078a7a
Compare
|
Flake #11560 [test] |
|
@ramr, @rajatchopra PTAL |
|
LGTM |
|
[test] |
|
Evaluated for origin test up to b078a7a |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11103/) (Base Commit: 54f5f92) |
|
[merge] Flaked on #10773 |
|
[merge] flaked on #10773 |
|
Evaluated for origin merge up to b078a7a |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11148/) (Base Commit: f7f9c83) (Image: devenv-rhel7_5319) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just cleans up how we handle compression support in the haproxy
config to make it more like the existing code. There is no functional
change.
The original code just went in as #11469