Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVEXP-424: Leveraging node pull secrets during image stream import #64

Closed
wants to merge 1 commit into from
Closed

DEVEXP-424: Leveraging node pull secrets during image stream import #64

wants to merge 1 commit into from

Conversation

ricardomaraschini
Copy link
Contributor

With this PR we start to use node's pull secrets during image stream import process as described on the enhancement proposal. We prioritize namespace secrets over node pull secrets.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 19, 2019
@dmage dmage mentioned this pull request Dec 19, 2019
Merged
@ricardomaraschini ricardomaraschini changed the title WIP: DEVEXP 424: Leveraging node pull secrets during image stream import DEVEXP 424: Leveraging node pull secrets during image stream import Jan 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 1, 2020
@ricardomaraschini
Copy link
Contributor Author

/assign @dmage @adambkaplan

@ricardomaraschini
Copy link
Contributor Author

/assign @mfojtik

@adambkaplan
Copy link
Contributor

/hold

Need to come to an agreement on the mount location, then ensure we set it correctly in openshift/cluster-openshift-apiserver-operator#284

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardomaraschini
To complete the pull request process, please assign adambkaplan
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricardomaraschini
Copy link
Contributor Author

/unhold

@adambkaplan once we came up with an agreement related to the path to use I am removing the hold on this one. openshift/enhancements#136 and openshift/cluster-openshift-apiserver-operator#284 were updated accordingly.

@ricardomaraschini
Copy link
Contributor Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
adambkaplan
adambkaplan reviewed Jan 23, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardomaraschini if I read this PR correctly, we don't explicitly need the openshift-apiserver-operator PR to merge first. As-is this PR will simply not find the node pull secret.

@ricardomaraschini
Copy link
Contributor Author

@ricardomaraschini if I read this PR correctly, we don't explicitly need the openshift-apiserver-operator PR to merge first. As-is this PR will simply not find the node pull secret.

Pretty much yes, you are correct.

@ricardomaraschini
Copy link
Contributor Author

/retest

@ricardomaraschini
Copy link
Contributor Author

/test e2e-cmd

@ricardomaraschini
Copy link
Contributor Author

/retest

@dmage
Copy link
Contributor

dmage commented Jan 29, 2020

/retitle DEVEXP-424: Leveraging node pull secrets during image stream import

@openshift-ci-robot openshift-ci-robot changed the title DEVEXP 424: Leveraging node pull secrets during image stream import DEVEXP-424: Leveraging node pull secrets during image stream import Jan 29, 2020
@adambkaplan
Copy link
Contributor

/hold

As this missed the feature freeze cutoff, we'll need to sit on this PR until 4.5 opens up

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2020
@ricardomaraschini
Copy link
Contributor Author

/unhold

4.5 is open

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2020
@ricardomaraschini
Copy link
Contributor Author

/hold preparing another version of this one.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2020
@ricardomaraschini
Copy link
Contributor Author

A new refactor version of this PR has been opened at #83, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan left review comments

@miminar miminar Awaiting requested review from miminar

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mfojtik mfojtik

@dmage dmage

@adambkaplan adambkaplan

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ricardomaraschini @adambkaplan @openshift-ci-robot @dmage @mfojtik