Fix python3 error in repoquery #4183
Conversation
Explicitly convert from bytes to string so that splitting the string is successful. This change works with python 2 as well. Closes openshift#4182
| @@ -48,7 +48,7 @@ def process_versions(query_output): | |||
|
|
|||
| version_dict = defaultdict(dict) | |||
|
|
|||
| for version in query_output.split('\n'): | |||
| for version in query_output.decode().split('\n'): | |||
There was a problem hiding this comment.
This will be hit by other items using _run (local ref). It may be a better fix to decode() before _run returns.
Here is what was done in lib_openshift.
| @@ -45,7 +45,7 @@ def test_querying_a_package(self, mock_cmd): | |||
|
|
|||
| # Return values of our mocked function call. These get returned once per call. | |||
| mock_cmd.side_effect = [ | |||
| (0, '4.2.46|21.el7_3|x86_64|rhel-7-server-rpms|4.2.46-21.el7_3', valid_stderr), # first call to the mock | |||
| (0, b'4.2.46|21.el7_3|x86_64|rhel-7-server-rpms|4.2.46-21.el7_3', valid_stderr), # first call to the mock | |||
There was a problem hiding this comment.
👍 as b'' in Python 2 will become a str while staying bytes in 3.
|
aos-ci-test |
|
[merge] |
|
flake openshift/origin#10773 |
|
[merge] |
|
Evaluated for openshift ansible merge up to 7fb814d |
|
[test]ing while waiting on the merge queue |
|
Evaluated for openshift ansible test up to 7fb814d |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/127/) (Base Commit: eedd16a) |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/407/) (Base Commit: 2677014) |
Explicitly convert from bytes to string so that splitting the string is
successful. This change works with python 2 as well.
Closes #4182