Skip to content

Commit

Permalink
Remove Docker 1.10 requirement temporarily.
Browse files Browse the repository at this point in the history
Docker 1.10 is not widely available in RHEL / CentOS yet, lets remove
the restriction for users of master / origin. We can revert as soon as
it's available publically.
  • Loading branch information
dgoodwin committed Jun 10, 2016
1 parent fea08b9 commit a797fee
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 31 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
- name: Check if Docker is installed
command: rpm -q docker
register: pkg_check
failed_when: pkg_check.rc > 1
changed_when: no

- name: Upgrade Docker
command: "{{ ansible_pkg_mgr}} update -y docker"
when: pkg_check.rc == 0 and g_docker_version.curr_version | version_compare('1.9','<')
register: docker_upgrade

- name: Restart Docker
command: systemctl restart docker
when: docker_upgrade | changed
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
# The restart playbook should be run after this playbook completes.
###############################################################################

- include: ../../../../byo/openshift-cluster/upgrades/docker/docker_upgrade.yml

- name: Update Docker facts
- name: Upgrade docker
hosts: oo_masters_to_config:oo_nodes_to_config:oo_etcd_to_config
roles:
- openshift_facts
tasks:
- include: docker_upgrade.yml
when: not openshift.common.is_atomic | bool
- name: Set post docker install facts
openshift_facts:
role: "{{ item.role }}"
Expand Down
28 changes: 0 additions & 28 deletions roles/docker/tasks/main.yml
Original file line number Diff line number Diff line change
@@ -1,32 +1,4 @@
---
# Going forward we require Docker 1.10 or greater. If the user has a lesser version installed they must run a separate upgrade process.
- name: Get current installed Docker version
command: "{{ repoquery_cmd }} --installed --qf '%{version}' docker"
when: not openshift.common.is_atomic | bool
register: curr_docker_version
changed_when: false

# TODO: The use of upgrading var will be removed in the coming upgrade refactor. This is a temporary
# fix to wory around the fact that right now, this role is called during upgrade, before we're
# ready to upgrade Docker.
- name: Fail if Docker upgrade is required
fail:
msg: "Docker {{ curr_docker_version.stdout }} must be upgraded to Docker 1.10 or greater"
when: not upgrading | bool and not curr_docker_version | skipped and curr_docker_version.stdout | default('0.0', True) | version_compare('1.10', '<')

- name: Get latest available version of Docker
command: >
{{ repoquery_cmd }} --qf '%{version}' "docker"
register: avail_docker_version
failed_when: false
changed_when: false
when: not curr_docker_version.stdout | default('0.0', True) | version_compare('1.10', '>=') and not openshift.common.is_atomic | bool

- name: Verify Docker >= 1.10 is available
fail:
msg: "Docker {{ avail_docker_version.stdout }} is available, but 1.10 or greater is required"
when: not avail_docker_version | skipped and avail_docker_version.stdout | default('0.0', True) | version_compare('1.10', '<')

- stat: path=/etc/sysconfig/docker-storage
register: docker_storage_check

Expand Down

0 comments on commit a797fee

Please sign in to comment.