Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-823: Address oadp-1.0.z with ocp 4.11 csi compatibility issue #848

Merged
merged 4 commits into from
Oct 6, 2022
Merged

OADP-823: Address oadp-1.0.z with ocp 4.11 csi compatibility issue #848

merged 4 commits into from
Oct 6, 2022

Conversation

shubham-pampattiwar
Copy link
Member

No description provided.

weshayutin
weshayutin reviewed Oct 6, 2022
View reviewed changes
controllers/validator.go Outdated Show resolved Hide resolved
@weshayutin
Copy link
Contributor

looks good to me.. I suspect we should add a unit test for this issue. Should be easy enough and can be in a follow up.
Thanks

@weshayutin
Copy link
Contributor

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
kaovilai
kaovilai requested changes Oct 6, 2022
View reviewed changes
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do

for _, plugin := range dpa.Spec.Configuration.Velero.DefaultPlugins {
  for _, plugin := range dpa.Spec.Configuration.Velero.DefaultPlugins {
  }
}

controllers/validator.go Outdated Show resolved Hide resolved
sseago
sseago approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@sseago sseago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

controllers/validator.go Outdated Show resolved Hide resolved
eemcmullan
eemcmullan reviewed Oct 6, 2022
View reviewed changes
controllers/validator.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
kaovilai
kaovilai approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Emily on condensing error string a bit. otherwise
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2022

@shubham-pampattiwar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rayfordj rayfordj merged commit cae07b8 into openshift:oadp-1.0 Oct 6, 2022
@kaovilai kaovilai mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshayutin weshayutin weshayutin left review comments

@eemcmullan eemcmullan eemcmullan approved these changes

@kaovilai kaovilai kaovilai approved these changes

@sseago sseago sseago approved these changes

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@weshayutin weshayutin

@kaovilai kaovilai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shubham-pampattiwar @weshayutin @sseago @kaovilai @eemcmullan @rayfordj