Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oadp-1.0: OADP-812 Reduce logging after reconciled is reached. #842

Merged
merged 10 commits into from
Oct 5, 2022
Merged

oadp-1.0: OADP-812 Reduce logging after reconciled is reached. #842

merged 10 commits into from
Oct 5, 2022

Conversation

kaovilai
Copy link
Member

Cherry-pick #841 into oadp-1.0

@kaovilai
Reduce update calls. Implement loglevel override.
905d5b1 
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@kaovilai
Copy link
Member Author

kaovilai commented Oct 3, 2022

/retest

@kaovilai kaovilai changed the title oadp-1.0: OADP-812 Reduce update calls. Implement loglevel override. oadp-1.0: OADP-812 Reduce logging after reconciled is reached. Oct 4, 2022
@kaovilai kaovilai requested review from shubham-pampattiwar and removed request for jwmatthews October 4, 2022 19:13
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@weshayutin
Copy link
Contributor

controller-manager logs from ci are here https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_oadp[…]controller-manager-64574b97d4-5c66f_manager.log

1.0.4 w/o the patch controller-manager logs are here: openshift-adp_openshift-adp-controller-manager-c7fc8bcc9-q4vmn_manager.log20285Wed, 28 Sep 2022 20:39:37 UTC

w/ patch:
size of logs: 5128
[whayutin@thinkdoe tmp]$ cat openshift-adp_openshift-adp-controller-manager-64574b97d4-5c66f_manager.log | grep "has been labelled" | wc -l
1

w/o patch:
size of logs: 20285
[whayutin@thinkdoe tmp]$ cat openshift-adp_openshift-adp-controller-manager-c7fc8bcc9-q4vmn_manager.log | grep "has been labelled" | wc -l
286

@weshayutin
Copy link
Contributor

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@kaovilai kaovilai merged commit 41d2459 into openshift:oadp-1.0 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemcmullan eemcmullan eemcmullan approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@rayfordj rayfordj rayfordj approved these changes

Assignees

@weshayutin weshayutin

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaovilai @weshayutin @rayfordj @shubham-pampattiwar @eemcmullan