[OADP-452 , OADP-490] Add labels to dpa podConfig, Fix velero pod (match)labels missing deploy: velero

[kaovilai]

You can now customize pod labels of velero and restic pods using podConfig configurable in DataProtectionApplication.
Closes OADP-452 , OADP-490

[kaovilai]

/test 4.10-operator-e2e-azure
/test 4.9-operator-e2e-azure
/test 4.8-operator-e2e-azure
/test 4.7-operator-e2e-azure

[kaovilai]

/test 4.9-operator-e2e-aws

[kaovilai]

/test 4.9-operator-e2e-aws

[kaovilai]

Looks like subscription suite test should add some waits to
/retest

[dymurray]

Wont this error out on existing user environments now that I think about it? Isn't the selector an immutable field?

[kaovilai]

Wont this error out on existing user environments now that I think about it? Isn't the selector an immutable field?

I'll test this. Maybe we need upgrade suite test.

[dymurray]

Wont this error out on existing user environments now that I think about it? Isn't the selector an immutable field?

I'll test this. Maybe we need upgrade suite test.

+1 I think that's a great idea. cc @weshayutin

[kaovilai]

basically install published CSVs and try install the new CSV over it and check no reconcile failures

[kaovilai]

Will do a quick manual test so we can get this merged or make changes. But will work on upgrade suite test later

[kaovilai]

Step to test upgrade
Add OADP-1.0.2 bundle to catalogsource image, build and push. Add as catalogsource

export GIT_REV=$(git rev-parse --short HEAD)
CATALOG_IMG=ttl.sh/oadp-operator-catalog-$GIT_REV:1h \
BUNDLE_IMG=registry.redhat.io/oadp/oadp-operator-bundle@sha256:101d6d1c97f56114ce44542395ccd8fe273f36a314939022ede79f60b7aa9654 \
make catalog-build catalog-push 

Install OADP operator from catalogsource, create DPA that reconciles. Check velero deployment is ready.

Build bundle for this PR

IMG=ttl.sh/oadp-operator-$GIT_REV:1h \
BUNDLE_IMG=ttl.sh/oadp-operator-bundle-$GIT_REV:1h \
CATALOG_BASE_IMG=ttl.sh/oadp-operator-catalog-$GIT_REV:1h \
CATALOG_IMG=ttl.sh/oadp-operator-catalog-$GIT_REV:1h \
make docker-build docker-push bundle bundle-build bundle-push catalog-build-replaces catalog-push

Wait for update to refresh on cluster. Auto or manual approve update. Check no errors on velero deployment or dpa.

where catalog-build-replaces comes from https://github.com/openshift/oadp-operator/pull/681/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R355

[kaovilai]

yup error

2022-05-10T20:28:11.966Z ERROR controller.dataprotectionapplication Reconciler error {"reconciler group": "oadp.openshift.io", "reconciler kind": "DataProtectionApplication", "name": "velero-sample", "namespace": "openshift-adp", "error": "Deployment.apps \"velero\" is invalid: spec.selector: Invalid value: v1.LabelSelector{MatchLabels:map[string]string{\"app.kubernetes.io/component\":\"server\", \"app.kubernetes.io/instance\":\"velero-sample\", \"app.kubernetes.io/managed-by\":\"oadp-operator\", \"app.kubernetes.io/name\":\"velero\", \"component\":\"velero\", \"deploy\":\"velero\", \"openshift.io/oadp\":\"True\"}, MatchExpressions:[]v1.LabelSelectorRequirement(nil)}: field is immutable"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/root/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.3/pkg/internal/controller/controller.go:227

[kaovilai]

/retest

[openshift-ci]

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.