Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running must gather after each tests #594

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Running must gather after each tests #594

merged 3 commits into from
Mar 31, 2022

Conversation

deepakraj1997
Copy link
Contributor

@deepakraj1997 deepakraj1997 commented Mar 11, 2022 •
edited
Loading

  • Was trying to run using oc client, but after some research, it may very cumbersome to run oc adm ... commands using oc go client.
  • Running must gather using shell.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #594 (5259e20) into master (6247a03) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   37.21%   37.21%           
=======================================
  Files          14       14           
  Lines        2937     2937           
=======================================
  Hits         1093     1093           
  Misses       1761     1761           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6247a03...5259e20. Read the comment docs.

@weshayutin
Copy link
Contributor

woot... thank you @deepakraj1997 for looking into this!

deepakraj1997 added a commit to deepakraj1997/oadp-operator that referenced this pull request Mar 17, 2022
@deepakraj1997
Adding gather_logs_without_zip script for the use case of openshift#594
3539cf4
@deepakraj1997 deepakraj1997 mentioned this pull request Mar 17, 2022
Merged
@deepakraj1997
Copy link
Contributor Author

/hold for #599

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2022
deepakraj1997 added a commit that referenced this pull request Mar 17, 2022
@deepakraj1997
Adding gather_logs_without_zip script for the use case of #594 (#599)
2b031b0
@deepakraj1997 deepakraj1997 marked this pull request as ready for review March 21, 2022 16:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2022
@deepakraj1997
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2022
@savitharaghunathan
Copy link
Member

/retest

1 similar comment
@deepakraj1997
Copy link
Contributor Author

/retest

@deepakraj1997
Copy link
Contributor Author

/test 4.8-operator-e2e 4.7-operator-e2e

@deepakraj1997
Copy link
Contributor Author

/test 4.8-operator-e2e

@hhpatel14
Copy link
Contributor

https://coreos.slack.com/archives/CFUGK0K9R/p1647955342187699 We are running our tests on build03.

@kaovilai
Copy link
Member

/retest

@deepakraj1997 deepakraj1997 changed the title Running must gather after each tests [WIP] Running must gather after each tests Mar 23, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2022
@deepakraj1997
Copy link
Contributor Author

/test 4.7-operator-e2e

@deepakraj1997
Copy link
Contributor Author

/test 4.8-operator-e2e

@deepakraj1997 deepakraj1997 mentioned this pull request Mar 23, 2022
Merged
@deepakraj1997
Copy link
Contributor Author

/hold for openshift/release#27197

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2022
@deepakraj1997
Copy link
Contributor Author

deepakraj1997 commented Mar 23, 2022 •
edited
Loading

Pending: To update using 'oc' from CLI_DIR

@deepakraj1997
Copy link
Contributor Author

/test 4.8-operator-e2e

@deepakraj1997
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2022
@deepakraj1997
Copy link
Contributor Author

/retest

4 similar comments
@deepakraj1997
Copy link
Contributor Author

/retest

@hhpatel14
Copy link
Contributor

/retest

@deepakraj1997
Copy link
Contributor Author

/retest

@deepakraj1997
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Mar 31, 2022

@deepakraj1997: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepakraj1997 deepakraj1997 changed the title [WIP] Running must gather after each tests Running must gather after each tests Mar 31, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2022
@deepakraj1997 deepakraj1997 merged commit 43feeba into openshift:master Mar 31, 2022
@weshayutin
Copy link
Contributor

NICE! @hhpatel14 FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

@weshayutin weshayutin Awaiting requested review from weshayutin

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

@jwmatthews jwmatthews Awaiting requested review from jwmatthews

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@deepakraj1997 @codecov-commenter @weshayutin @savitharaghunathan @hhpatel14 @kaovilai