CloudStorage: Only delete and remove finalizer if there exists an annotation.

[kaovilai]

New:

• Annotation oadp.openshift.io/cloudstorage-delete: "true" is now required to trigger bucket deletion

Fix:

• If bucket is deleted successfully at the cloud provider, a finalizer on the CR is removed so the CR goes deletion continues
• Add checks such that finalizer is only added if deletionTimestamp is nil.

Example annotation

metadata:
  annotations:
    oadp.openshift.io/cloudstorage-delete: "true"

If user wants to remove the CloudStorage custom resource from the cluster without deleting bucket from cloud provider, they can do so by

• Don't add oadp.openshift.io/cloudstorage-delete: "true" annotation
• oc delete cloudstorage/<name>
• remove finalizer

kubectl patch -n openshift-adp cloudstorage/<name> \
    --type json \
    --patch='[ { "op": "remove", "path": "/metadata/finalizers" } ]'

[kaovilai]

Annotation ("oadp.openshift.io/cloudstorage-delete": "true") to activate bucket deletion in cloud providers, finalizer will be removed for you.

To remove CR without deleting bucket in cloud storage, user just have to remove finalizer.

[codecov-commenter]

Codecov Report

Merging #574 (b402ffa) into master (5a5cf32) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
- Coverage   37.60%   37.30%   -0.31%     
==========================================
  Files          14       14              
  Lines        2917     2941      +24     
==========================================
  Hits         1097     1097              
- Misses       1737     1761      +24     
  Partials       83       83              

Impacted Files	Coverage Δ
controllers/bucket_controller.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a5cf32...b402ffa. Read the comment docs.

[kaovilai]

/test 4.7-operator-unit-test

[shawn-hurley]

I think the event needs to look different

[shawn-hurley]

LGTM after updating the event names

[kaovilai]

/retest

[openshift-ci]

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.