Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process extensions before file updates #3874

Closed
wants to merge 1 commit into from

Conversation

yuvalk
Copy link
Contributor

@yuvalk yuvalk commented Aug 17, 2023

so that files/ systemd units can rely on extensions in the same MC

Closes: OCPBUGS-17826

- What I did
I changed the order by which update is applied, so that extensions are processed before files (systemd, file content, etc)

- How to verify it
try with the following mc spec:

  config:
    ignition:
      version: 3.2.0
  extensions:
    - ipsec
  systemd:
    units:
    - name: ipsec.service
      enabled: true

- Description for the changelog
change update apply order so that extensions can be specified with systemd units that relate to extension content

so that files/ systemd units can rely on extensions in the same MC
@openshift-ci openshift-ci bot requested review from cdoern and yuqi-zhang August 17, 2023 03:13
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuvalk
Once this PR has been reviewed and has the lgtm label, please assign sinnykumari for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuvalk
Copy link
Contributor Author

yuvalk commented Aug 17, 2023

/test verify

@yuvalk
Copy link
Contributor Author

yuvalk commented Aug 17, 2023

/test unit

@yuvalk
Copy link
Contributor Author

yuvalk commented Aug 17, 2023

/test e2e-hypershift

@yuvalk
Copy link
Contributor Author

yuvalk commented Aug 17, 2023

/test e2e-aws-ovn-upgrade

@sinnykumari
Copy link
Contributor

Unfortunately this is not going to help for this usecase. Extensions and OSUpdates are applied using rpm-ostree and this results into a new deployment. They don't get reflected to current OS deployment to which it has been booted. While, any writing file/ systemd service and any processing to it happen to booted deployment on RHCOS node.

@yuvalk
Copy link
Contributor Author

yuvalk commented Aug 17, 2023

Unfortunately this is not going to help for this usecase. Extensions and OSUpdates are applied using rpm-ostree and this results into a new deployment. They don't get reflected to current OS deployment to which it has been booted. While, any writing file/ systemd service and any processing to it happen to booted deployment on RHCOS node.

right, that would be too easy ;-)

@yuvalk yuvalk closed this Aug 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2023

@yuvalk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift f3a459a link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Member

This relates to #1190 which is going to be fixed by the in-cluster build and layering because we consistently and transactionally update the OS and configuration as one unit in this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants