-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process extensions before file updates #3874
Conversation
so that files/ systemd units can rely on extensions in the same MC
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yuvalk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test verify |
/test unit |
/test e2e-hypershift |
/test e2e-aws-ovn-upgrade |
Unfortunately this is not going to help for this usecase. Extensions and OSUpdates are applied using rpm-ostree and this results into a new deployment. They don't get reflected to current OS deployment to which it has been booted. While, any writing file/ systemd service and any processing to it happen to booted deployment on RHCOS node. |
right, that would be too easy ;-) |
@yuvalk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This relates to #1190 which is going to be fixed by the in-cluster build and layering because we consistently and transactionally update the OS and configuration as one unit in this approach. |
so that files/ systemd units can rely on extensions in the same MC
Closes: OCPBUGS-17826
- What I did
I changed the order by which update is applied, so that extensions are processed before files (systemd, file content, etc)
- How to verify it
try with the following mc spec:
- Description for the changelog
change update apply order so that extensions can be specified with systemd units that relate to extension content