-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE-2962: configure ovs should use node-ip-hint set by nodeip-configuration #3362
RFE-2962: configure ovs should use node-ip-hint set by nodeip-configuration #3362
Conversation
…figuration is not running
/test e2e-azure-ovn-upgrade |
/test e2e-azure-upgrade |
/retest |
/retest It looks like this is now working as intended and one azure-upgrade job passed so I expect the ovn one should too. |
/test e2e-aws-ovn-workers-rhel8 |
Failures in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/3362/pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade/1577237776590442497 do not look related. I think we can see enough in presubmits to say no payload command required. Thanks! |
Failures seem unrelated. Going for another round just in case. /retest |
/lgtm |
@cgwalters can we get approve? |
/approve |
/retest |
Failures seems totally unrelated |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, flaper87, jcaamano, tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/retest |
/retest-required |
/test okd-scos-images |
@tsorya: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
When dealing with IPv6 addresses we need to make sure they are bindable before we report network as ready. The check has been introduced in openshift#3362 and works by trying to simply bind to a specified IPv6 address. The check however doesn't account for the fact that we may have addresses in the form of IPv4-mapped-on-IPv6. In such a scenario ncat is returning an "Invalid argument" error because it tries to open a socket of type `AF_INET6` whereas this type of address requires additional `IPV6_ADDRFORM` option which ncat is not setting. Another possibility is to create a socket of type `AF_INET` what could be done by ``` nc -4 -l ::ffff:192.168.0.14 53604 ``` In order to workaround this behaviour of netcat, we are ignoring the bind tests for IPv4-mapped-on-IPv6 address, as due to its nature it will never be stuck in tentative state even when rest of the infrastrucure is performing Duplicate Address Detection. As this address belongs to a special class of addresses, we can afford its special handling. Closes: OCPBUGS-10695
RFE-2962: configure ovs should use node-ip-hint set by nodeip-configuration