[release-4.1] Bug 1782153: templates/container-storage: Add a "this is generated" note #1324
Conversation
It's identical between master/worker, so move it into the common pool. Just a cleanup while looking at openshift#1319
This is a best practice, and particularly in this case when we're intending to modify a config file, it can't be identical to the shipped version. This avoids having libostree replace it with a newer version. Closes: openshift#1319
|
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle [release-4.1] Bug 1782153: templates/container-storage: Add a "this is generated" note |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1782153, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
|
@openshift-bot: This pull request references Bugzilla bug 1782153, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This is failing units because it was only in 4.2 that we landed #749 |
|
This one might just need to be reworked manually - basically drop the common/ prep patch and change both copies manually, then bump the test suite. |
|
I think unit test is failing because we don't have templates/common dir in 4.1 branch https://github.com/openshift/machine-config-operator/tree/release-4.1/templates . Seems to me that adding container-storage.yaml in templates/common/ directory doesn't get handled well in 4.1 , Maybe we should modify the PR to add the generated comment in container-storage.yaml file in both worker and master dir directly? |
|
Lets close automated cherry-pick and make 4.1 PR manually /close |
|
@vrutkovs: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vrutkovs since you were on to this, would be interested in sending a manual PR for 4.1? |
This is an automated cherry-pick of #1320
/assign vrutkovs