Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop x-operator and integrate with cvo, following pattern from machine-config-operator #67

Merged
merged 12 commits into from
Sep 21, 2018
Merged

Drop x-operator and integrate with cvo, following pattern from machine-config-operator #67

merged 12 commits into from
Sep 21, 2018

Conversation

vikaschoudhary16
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2018
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 21, 2018
@vikaschoudhary16 vikaschoudhary16 changed the title Add lib for resourceapply, resourcemerge and resourceread Add changes to clean git history Sep 21, 2018
@vikaschoudhary16 vikaschoudhary16 changed the title Add changes to clean git history [WIP]Add changes to clean git history Sep 21, 2018
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 21, 2018
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 21, 2018
@vikaschoudhary16 vikaschoudhary16 changed the title [WIP]Add changes to clean git history Add changes to clean git history Sep 21, 2018
@vikaschoudhary16 vikaschoudhary16 changed the base branch from cvo-integration to master September 21, 2018 08:48
@enxebre
Copy link
Member

enxebre commented Sep 21, 2018

/test e2e

@vikaschoudhary16 vikaschoudhary16 force-pushed the dev branch 2 times, most recently from 819faf8 to 9a5b177 Compare September 21, 2018 09:41
@vikaschoudhary16 vikaschoudhary16 changed the title Add changes to clean git history Drop x-operator and integrate with cvo, following pattern from machine-config-operator Sep 21, 2018
@enxebre
Copy link
Member

enxebre commented Sep 21, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, vikaschoudhary16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [enxebre,vikaschoudhary16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a67b759 into openshift:master Sep 21, 2018
@wking wking mentioned this pull request Sep 24, 2018
Closed
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
@openshift-merge-robot
Merge pull request openshift#67 from enxebre/crds
261db4a 
Migrate to CRDs - WIP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@spangenberg spangenberg Awaiting requested review from spangenberg

Assignees

@enxebre enxebre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vikaschoudhary16 @enxebre @openshift-ci-robot @openshift-merge-robot