Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mao: add support for the vsphere platform #261

Merged
merged 1 commit into from
Apr 16, 2019
Merged

mao: add support for the vsphere platform #261

merged 1 commit into from
Apr 16, 2019

Conversation

staebler
Copy link
Contributor

@staebler staebler commented Mar 29, 2019 •
edited
Loading

The vsphere platform is a no-op for mao, like the none platform.

Adds a unit test to ensure that the mao reports available for no-op platforms.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 29, 2019
frobware
frobware requested changes Mar 29, 2019
View reviewed changes
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2019
@enxebre enxebre mentioned this pull request Apr 1, 2019
Closed
@enxebre
Copy link
Member

enxebre commented Apr 1, 2019 •
edited
Loading

since #264 got merged. Once this get's merged #266 vSphere will already no-op and we'll just need to rebase this and include the relevant unit tests

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 2, 2019
@staebler staebler changed the title mao: add support for vsphere provider type mao: add support for the vsphere platform Apr 2, 2019
@staebler
Copy link
Contributor Author

staebler commented Apr 2, 2019

9114986...2dbe66c brings this PR in line with the changes from #264 and #266.

enxebre
enxebre reviewed Apr 2, 2019
View reviewed changes
pkg/operator/operator_test.go
err = optr.sync("test-key")
if tc.expectedSyncError {
if !assert.Error(t, err, "unexpected sync success") {
t.Fatal()
Copy link
Member

@enxebre enxebre Apr 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why Fatal? from the docs: "it will call failNow and stops function execution", why not just asset.Error so the loop keep going and we output for each case. Same for all below this line
cc @frobware

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With sub-tests, the call to Fatal will only fail the one sub-test. The rest of the sub-tests will still execute.

Copy link
Member

@enxebre enxebre Apr 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so what's the difference over just if !tc.expectedNoop { assert.Error(t, err, "unexpected sync success")}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is that with your code, the rest of the sub-test will be executed. So there will be more test errors later on in the sub-test when it comes to testing the conditions set on the clusteroperator. That is not terribly; it does make the test results harder to analyze due to more noise, however.

I am fine with removing the call to Fatal here, if you prefer. The call to Fatal at

machine-api-operator/pkg/operator/operator_test.go

Lines 108 to 111 in 67a8e84

o, err := optr.osClient.ConfigV1().ClusterOperators().Get(clusterOperatorName, metav1.GetOptions{})
if !assert.NoError(t, err, "failed to get clusteroperator") {
t.Fatal()
}
needs to stay to prevent a panic when the clusteroperator does not exist.

@staebler staebler force-pushed the vsphere_provider branch 2 times, most recently from d28b7cb to 67a8e84 Compare April 2, 2019 13:46
@staebler
Copy link
Contributor Author

staebler commented Apr 2, 2019

d28b7cb...67a8e84 simplified the test cases for the operator sync test.

@enxebre
Copy link
Member

enxebre commented Apr 2, 2019

thanks a lot @staebler
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2019
@enxebre
Copy link
Member

enxebre commented Apr 3, 2019

/retest

@enxebre
Copy link
Member

enxebre commented Apr 10, 2019

needs rebase

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre
Copy link
Member

enxebre commented Apr 12, 2019

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@enxebre
Copy link
Member

enxebre commented Apr 15, 2019

this should go green now #286
/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@staebler: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 12e66da link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 062b230 into openshift:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre enxebre left review comments

@frobware frobware frobware approved these changes

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@frobware frobware

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@staebler @enxebre @openshift-ci-robot @frobware @openshift-bot @openshift-merge-robot