Bug 1926484: UPSTREAM: <carry>: kube-apiserver: ignore SIGTERM/INT after the first one #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sttts: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
c86e461 to
2003be5
Compare
|
@sttts: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
Fixed two compilation errors. |
|
Opened https://bugzilla.redhat.com/show_bug.cgi?id=1926484 to use as a bugzilla for this. |
|
Running an upgrade from this PR to 4.8 latest in https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-gcp/1358979509927284736 |
p0lyn0mial
reviewed
Feb 9, 2021
| @@ -47,8 +49,15 @@ func SetupSignalContext() context.Context { | |||
| go func() { | |||
| <-shutdownHandler | |||
| cancel() | |||
| <-shutdownHandler | |||
| os.Exit(1) // second signal. Exit directly. | |||
| if exitOnSecondSignal { | |||
There was a problem hiding this comment.
Temporary in the sense of a downstream carry.
See description for background.
|
@sttts: This pull request references Bugzilla bug 1926484, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sttts: This pull request references Bugzilla bug 1926484, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/tetest |
p0lyn0mial
reviewed
Feb 9, 2021
| @@ -38,7 +38,7 @@ func main() { | |||
| logs.InitLogs() | |||
| defer logs.FlushLogs() | |||
|
|
|||
| stopCh := genericapiserver.SetupSignalHandler() | |||
| stopCh := genericapiserver.SetupSignalHandler(false) | |||
There was a problem hiding this comment.
shouldn't this be set to true? I think this is a standalone binary.
There was a problem hiding this comment.
true. Nobody uses it, but yes. Fixing.
2003be5 to
c4adb51
Compare
|
@sttts: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
|
|
/test configmap-scale |
|
@rsevilla87: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold until we have proof it helps cc @mrunalp @smarterclayton |
|
/test configmap-scale |
atiratree
pushed a commit
to atiratree/kubernetes
that referenced
this pull request
Sep 13, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
atiratree
pushed a commit
to atiratree/kubernetes
that referenced
this pull request
Sep 20, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
atiratree
pushed a commit
to atiratree/kubernetes
that referenced
this pull request
Sep 20, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
atiratree
pushed a commit
to atiratree/kubernetes
that referenced
this pull request
Sep 25, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
atiratree
pushed a commit
to atiratree/kubernetes
that referenced
this pull request
Oct 1, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Nov 26, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Nov 26, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Nov 27, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Nov 27, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Nov 28, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Nov 28, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Nov 29, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Nov 29, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 2, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 4, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 4, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 4, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 5, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 6, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 7, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 9, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 10, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 11, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 11, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 11, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 12, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 16, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Dec 17, 2024
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Jan 16, 2025
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
Jan 16, 2025
… one UPSTREAM: <carry>: kube-apiserver: set up separate signal handler functions to ignore further signals This patches the changes from openshift#558 to provide these new functions without changing the behavior for other repos that depend on them, such as library-go. OpenShift-Rebase-Source: 63ed200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally kubelet sends SIGTERM to root process of container on graceful shutdown. But during node shutdown, systemd is the actor sending the signal instead. And systemd sends SIGTERM to every process. As we have the
watch-terminationwrapper, both systemd sends SIGTERM andwatch-terminationforwards => 2 SIGTERMs arrive at kube-apiserver, which makes it shutdown hard (os.Exit(1)).This PR make kube-apiserver ignore a second SIGTERM.