Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: <carry>: Update kubensenter to use exec instead of subprocess #1350

Merged
merged 1 commit into from
Aug 25, 2022
Merged

UPSTREAM: <carry>: Update kubensenter to use exec instead of subprocess #1350

merged 1 commit into from
Aug 25, 2022

Conversation

lack
Copy link
Member

@lack lack commented Aug 23, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Because kubelet relies on systemd's Type=notify mechanism, we don't need
or want kubensenter to keep itself in the process tree. exec is best.

Special notes for your reviewer:

See discussion here for more context, if needed: openshift/machine-config-operator#3274 (comment)

Does this PR introduce a user-facing change?

NONE

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 23, 2022
@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 23, 2022
@openshift-ci-robot
Copy link

@lack: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@lack
Copy link
Member Author

lack commented Aug 23, 2022

/cc @rphillips @deads2k

@openshift-ci openshift-ci bot requested review from deads2k, rphillips and sttts August 23, 2022 15:45
@rphillips
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@lack lack mentioned this pull request Aug 23, 2022
Merged
@lack lack changed the title UPSTREAM: <carry>: Update kubensenter to use exec instead of direct call UPSTREAM: <carry>: Update kubensenter to use exec instead of subprocess Aug 23, 2022
@deads2k
Copy link

deads2k commented Aug 23, 2022

/approve

@deads2k deads2k removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 23, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD ed93380 and 8 for PR HEAD 01d1b4888b25a67db56f54e4efcb8d59cd7eb88a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD ed93380 and 7 for PR HEAD 01d1b4888b25a67db56f54e4efcb8d59cd7eb88a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ed93380 and 6 for PR HEAD 01d1b4888b25a67db56f54e4efcb8d59cd7eb88a in total

@lack
Copy link
Member Author

lack commented Aug 23, 2022

/retest-required

1 similar comment
@lack
Copy link
Member Author

lack commented Aug 24, 2022

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD ee4fa9b and 5 for PR HEAD 01d1b4888b25a67db56f54e4efcb8d59cd7eb88a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD d6a97e1 and 4 for PR HEAD 01d1b4888b25a67db56f54e4efcb8d59cd7eb88a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD d6a97e1 and 3 for PR HEAD 01d1b4888b25a67db56f54e4efcb8d59cd7eb88a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD c83b5d0 and 2 for PR HEAD 01d1b4888b25a67db56f54e4efcb8d59cd7eb88a in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD c83b5d0 and 1 for PR HEAD 01d1b4888b25a67db56f54e4efcb8d59cd7eb88a in total

@lack
UPSTREAM: <carry>: Update kubensenter to use exec instead of direct call
de8c6e9 
Because kubelet relies on systemd's Type=notify mechanism, we don't need
or want kubensenter to keep itself in the process tree. exec is best.

Signed-off-by: Jim Ramsay <jramsay@redhat.com>
@lack lack force-pushed the kubensenter_exec branch from 01d1b48 to de8c6e9 Compare August 25, 2022 14:27
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 25, 2022
@openshift-ci-robot
Copy link

@lack: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@rphillips
Copy link

/lgtm

@deads2k deads2k removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 25, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, deads2k, lack, mrunalp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD c83b5d0 and 8 for PR HEAD de8c6e9 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD c83b5d0 and 7 for PR HEAD de8c6e9 in total

@openshift-ci
Copy link

openshift-ci bot commented Aug 25, 2022

@lack: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade de8c6e9 link false /test 4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a097e26 into openshift:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp approved these changes

@cgwalters cgwalters cgwalters approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@rphillips rphillips Awaiting requested review from rphillips

@sttts sttts Awaiting requested review from sttts

Assignees

@rphillips rphillips

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lack @openshift-ci-robot @rphillips @deads2k @mrunalp @cgwalters @openshift-merge-robot