Skip to content

Commit

Permalink
fixed wrong warning in kube-proxy regarding topology aware hints
Browse files Browse the repository at this point in the history
  • Loading branch information
dervoeti committed May 12, 2021
1 parent e388e5e commit dbc2863
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/proxy/topology.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,12 @@ func filterEndpointsWithHints(endpoints []Endpoint, hintsAnnotation string, node
}
}

if len(filteredEndpoints) > 0 {
if len(filteredEndpoints) == 0 {
klog.Warningf("Skipping topology aware endpoint filtering since no hints were provided for zone %s", zone)
return filteredEndpoints
return endpoints
}

return endpoints
return filteredEndpoints
}

// deprecatedTopologyFilter returns the appropriate endpoints based on the
Expand Down

0 comments on commit dbc2863

Please sign in to comment.