Skip to content

Commit

Permalink
Merge pull request #1453 from stlaz/podextractor_fixup
Browse files Browse the repository at this point in the history
Fix the mutated PodSpec extractor for warns if no SCC matches
  • Loading branch information
openshift-merge-robot authored Jan 16, 2023
2 parents 099791b + b4e019f commit 7dab57f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func (s *SCCMutatingPodSpecExtractor) ExtractPodSpec(obj runtime.Object) (*metav
klog.ErrorS(err, "failed to mutate object for PSA using SCC")
utilruntime.HandleError(fmt.Errorf("failed to mutate object for PSA using SCC: %w", err))
// TODO remove this failure we're causing when SCC fails, but for now we actually need to see our test fail because that was almost really bad.
return podTemplateMeta, originalPodSpec, err
return podTemplateMeta, originalPodSpec, nil
}

if err := v1.Convert_core_Pod_To_v1_Pod(internalPod, pod, nil); err != nil {
Expand Down

0 comments on commit 7dab57f

Please sign in to comment.