Feature/custom secret name #283
Conversation
To change the default name of the secret (originally "namespace-secretname"), We can now give a custom name to the secret using "jenkins.openshift.io/secret.name" annotation. ``` annotations: jenkins.openshift.io/secret.name: CustomeName ```
Updated README with info on how to override the jenkins secret names.
|
Hi @waveywaves. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
| @@ -11,14 +11,14 @@ the Jenkins Credentials Plugin. | |||
| * changes in a Jenkins Build Run thats associated with a Jenkins Job gets replicated to an OpenShift Build object (which is created if necessary if the build was triggered via Jenkins) | |||
| * changes in OpenShift ConfigMap resources are examined for XML documents that correspond to Pod Template configuration for the Kubernetes Cloud plugin at http://github.com/jenkinsci/kubernetes-plugin and change the configuration of the Kubernetes Cloud plugin running in Jenkins to add, edit, or remove Pod Templates based on what exists in the ConfigMap; also note, if the <image></image> setting of the Pod Template starts with "imagestreamtag:", then this plugin will look up the ImageStreamTag for that entry (stripping "imagestreamtag:" first) and if found, replace the entry with the ImageStreamTag's Docker image reference. | |||
| * changes to OpenShift ImageStream resources with the label "role" set to "jenkins-slave" and ImageStreamTag resources with the annotation "role" set to "jenkins-slave" are considered images to used with Pod Templates for the Kubernetes Cloud plugin, where the Pod Templates are added, modified, or deleted from the Kubernetes cloud plugin as corresponding ImageStreams and ImageStreamTags are added, modified, or deleted, or have the "role=jenkins-slave" setting changed. | |||
| * changes to Openshift Secrets with the annotation "jenkins.openshift.io/secret.name" set to any custom name for the secret will result in the name of the Secret being overridden provided that, no other secret has the same identifier. | |||
There was a problem hiding this comment.
I'll fix this after it merges ... I want it placed as a sub-bullet under the next bullet and restructure to note what the default name will be, and then go into what setting the new annotation does
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
thanks @waveywaves ! |
This feature allows for overriding the default secret name which is of the format
namespace-secretnamewith a secret name of the users choice by adding an annotation in the Openshift Secret "jenkins.openshift.io/secret.name" and its value being any name given by the user provided that a secret of the same name does not exist.Fixes #271
cc @gabemontero