OCPBUGS-43779: Destroy all private cluster backend service resources #9270
Conversation
|
@barbacbd: This pull request references Jira Issue OCPBUGS-43779, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@barbacbd: This pull request references Jira Issue OCPBUGS-43779, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
8e7dcdb to
d4a60c9
Compare
|
/jira refresh |
|
@jianli-wei: This pull request references Jira Issue OCPBUGS-43779, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label qe-approved |
pkg/destroy/gcp/cloudcontroller.go
Outdated
|
|
||
| fwList, err := o.computeSvc.Firewalls.List(o.ProjectID).Fields(googleapi.Field("items(name,targetTags),nextPageToken")).Context(ctx).Do() | ||
| if err != nil { | ||
| o.Logger.Debugf("failed to list firewall rules associated with backend service %s", item.Name) |
There was a problem hiding this comment.
| o.Logger.Debugf("failed to list firewall rules associated with backend service %s", item.Name) | |
| o.Logger.Debugf("failed to list firewall rules associated with backend service %s: %v", item.Name, err) |
** When a private cluster was created, the destroy process would not find and destroy the backend services. This was happening specifically when no backends were created/found. The backend service could not be 100% associated with the cluster so it was skipped. Now, when the backend service is found, check the associated resources (for example the health checks or forwarding rules) for their tags/labels. If the resource(s) have tags that contain the cluster ID then the group of resources is considered part of the cluster and should be deleted.
d4a60c9 to
110a794
Compare
|
/lgtm |
|
@barbacbd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve For this tricky fix, it would help indicating the backend services we do end up deleting in debug msgs for better trigae/debugging in the future. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label acknowledge-critical-fixes-only |
78adb29
into
openshift:master
|
@barbacbd: Jira Issue OCPBUGS-43779: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-43779 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
/cherry-pick release-4.18 release-4.17 |
|
@barbacbd: new pull request created: #9380 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
** When a private cluster was created, the destroy process would not find and destroy the backend services. This was happening specifically when no backends were created/found. The backend service could not be 100% associated with the cluster so it was skipped. Now, when the backend service is found, check the associated resources (for example the health checks or forwarding rules) for their tags/labels. If the resource(s) have tags that contain the cluster ID then the group of resources is considered part of the cluster and should be deleted.