Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-2078: Enable VolumeAttributesClass on AWS EBS for resizer + provisioner #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

STOR-2078: Enable VolumeAttributesClass on AWS EBS for resizer + provisioner #314

wants to merge 1 commit into from

Conversation

dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Nov 5, 2024

Add RBAC ClusterRoleBinding for resizer + provisioner

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 5, 2024 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-2078 which is a valid jira issue.

In response to this:

Add RBAC ClusterRoleBinding for resizer + provisioner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bertinatto and tsmetana November 5, 2024 16:45
@dfajmon dfajmon force-pushed the volumeattributesclass branch 5 times, most recently from f12790b to 2bc4d9d Compare November 6, 2024 14:34
@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 7, 2024

/retest

@dfajmon dfajmon force-pushed the volumeattributesclass branch 2 times, most recently from 94204ec to d73ac75 Compare November 7, 2024 12:48
@jsafrane
Copy link
Contributor

jsafrane commented Nov 7, 2024

AWS EBS CSI driver operator did not start, because:

I1107 14:16:48.033705 1 simple_featuregate_reader.go:171] Starting feature-gate-detector
W1107 14:16:48.034638 1 reflector.go:547] k8s.io/client-go@v0.30.2/tools/cache/reflector.go:232: failed to list *v1.FeatureGate: featuregates.config.openshift.io is forbidden: User "system:serviceaccount:openshift-cluster-csi-drivers:aws-ebs-csi-driver-operator" cannot list resource "featuregates" in API group "config.openshift.io" at the cluster scope
E1107 14:16:48.034667 1 reflector.go:150] k8s.io/client-go@v0.30.2/tools/cache/reflector.go:232: Failed to watch *v1.FeatureGate: failed to list *v1.FeatureGate: featuregates.config.openshift.io is forbidden: User "system:serviceaccount:openshift-cluster-csi-drivers:aws-ebs-csi-driver-operator" cannot list resource "featuregates" in API group "config.openshift.io" at the cluster scope
W1107 14:16:48.034691 1 reflector.go:547] k8s.io/client-go@v0.30.2/tools/cache/reflector.go:232: failed to list *v1.ClusterVersion: clusterversions.config.openshift.io is forbidden: User "system:serviceaccount:openshift-cluster-csi-drivers:aws-ebs-csi-driver-operator" cannot list resource "clusterversions" in API group "config.openshift.io" at the cluster scope

cluster-storage-operator needs to permit those, like we do to vSphere CSI driver operator:
https://github.com/openshift/cluster-storage-operator/blob/c084d80f889951fbc9e726b87a904301f4759bd4/assets/csidriveroperators/vsphere/06_clusterrole.yaml#L298-L299

@dfajmon dfajmon force-pushed the volumeattributesclass branch 2 times, most recently from a2e3572 to e96566a Compare November 8, 2024 07:16
@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 11, 2024

/retest

4 similar comments
@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 12, 2024

/retest

@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 13, 2024

/retest

@gnufied
Copy link
Member

gnufied commented Nov 19, 2024

/retest

@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 20, 2024

/retest

@dfajmon dfajmon force-pushed the volumeattributesclass branch 3 times, most recently from 3152a94 to 063a799 Compare November 20, 2024 15:29
@dfajmon
Enable VolumeAttributesClass on AWS EBS for resizer + provisioner
54f6633 
Add RBAC ClusterRoleBinding for resizer + provisioner
@dfajmon dfajmon force-pushed the volumeattributesclass branch from 063a799 to 54f6633 Compare November 21, 2024 15:57
@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 22, 2024

this will need to be merged after this PR
openshift/release#58976

@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 22, 2024

/retest

@gnufied
Copy link
Member

gnufied commented Nov 22, 2024

/retest

@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 25, 2024

/retest-required

@RomanBednar RomanBednar mentioned this pull request Nov 26, 2024
Merged
@RomanBednar
Copy link
Contributor

/retest-required

2 similar comments
@RomanBednar
Copy link
Contributor

/retest-required

@dfajmon
Copy link
Contributor Author

dfajmon commented Nov 27, 2024

/retest-required

@RomanBednar
Copy link
Contributor

I think we're missing permissions/verbs at aws-ebs-csi-driver-operator-clusterrole for volumeattributesclass.

@jsafrane jsafrane mentioned this pull request Dec 3, 2024
Merged
@dfajmon
Copy link
Contributor Author

dfajmon commented Dec 3, 2024

/retest

2 similar comments
@jsafrane
Copy link
Contributor

jsafrane commented Dec 3, 2024

/retest

@dfajmon
Copy link
Contributor Author

dfajmon commented Dec 4, 2024

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

@dfajmon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-manila-csi 063a799 link true /test e2e-openstack-manila-csi
ci/prow/e2e-openstack 063a799 link false /test e2e-openstack
ci/prow/e2e-azurestack-csi 54f6633 link false /test e2e-azurestack-csi
ci/prow/smb-win-operator-e2e 54f6633 link false /test smb-win-operator-e2e
ci/prow/okd-scos-e2e-aws-ovn 54f6633 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor

jsafrane commented Dec 5, 2024

/lgtm
/approve
/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Dec 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfajmon, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@jsafrane jsafrane mentioned this pull request Dec 17, 2024
Merged
@radeore
Copy link

radeore commented Jan 8, 2025

Pre-merge testing results looks good.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2025 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-2078 which is a valid jira issue.

In response to this:

Add RBAC ClusterRoleBinding for resizer + provisioner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@bertinatto bertinatto Awaiting requested review from bertinatto

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dfajmon @openshift-ci-robot @jsafrane @gnufied @RomanBednar @radeore