Bug 2008120: Adjust dropped cAdvisor metrics #1404

philipgough · 2021-09-29T06:05:35Z

Backport of #1402

I added CHANGELOG entry for this change.
No user facing changes, so no entry in CHANGELOG was needed.

We drop some pod-centric metrics from cAdvisor to reduce cardinality. This metrics are available at the slice level.

openshift-ci · 2021-09-29T06:05:36Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2021-09-29T06:05:39Z

@philipgough: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-29T06:05:54Z

@philipgough: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-09-29T06:08:21Z

@philipgough: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

philipgough · 2021-09-29T08:47:47Z

/retest

philipgough · 2021-09-29T08:48:02Z

/skip

juzhao · 2021-09-30T09:50:35Z

tested with the PR, search metrics from prometheus with

count(container_fs_writes_total) by (id)
count(container_blkio_device_usage_total) by (id)

could see the metrics with id

{id="/"}
{id="/system.slice"}
{id="/system.slice/crio.service"}
{id="/kubepods.slice"}
{id="/kubepods.slice/kubepods-besteffort.slice"}

note: if you want to see result for "{id="/kubepods.slice/kubepods-besteffort.slice"}", make sure you have qosClass: BestEffort running pods
/label qe-approved

juzhao · 2021-09-30T09:50:41Z

/lgtm

openshift-ci · 2021-09-30T09:51:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juzhao, PhilipGough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [PhilipGough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

philipgough · 2021-09-30T09:59:33Z

/skip

philipgough · 2021-09-30T09:59:44Z

/retest

openshift-bot · 2021-09-30T12:11:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-08T01:00:51Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-08T01:00:54Z

@openshift-bot: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-09T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-09T01:01:19Z

@openshift-bot: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-10T01:01:15Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-10T01:01:19Z

@openshift-bot: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-11T01:00:44Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-11T01:00:47Z

@openshift-bot: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-12T01:00:47Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-12T01:00:51Z

@openshift-bot: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-13T01:01:07Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-13T01:01:11Z

@openshift-bot: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

simonpasquier · 2021-10-13T11:54:08Z

/label backport-risk-assessed

openshift-bot · 2021-10-14T01:01:14Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-14T01:01:18Z

@openshift-bot: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-10-15T01:01:03Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2021-10-15T01:01:07Z

@openshift-bot: This pull request references Bugzilla bug 2008120, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "4.9.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2021-10-15T18:04:47Z

/bugzilla refresh

openshift-ci · 2021-10-15T18:04:56Z

@sdodson: This pull request references Bugzilla bug 2008120, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.z) matches configured target release for branch (4.9.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 2007677 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 2007677 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-10-15T21:46:58Z

@philipgough: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/versions	`b54a0d6`	link	true	`/test versions`
ci/prow/e2e-aws-single-node	`b54a0d6`	link	false	`/test e2e-aws-single-node`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-10-15T21:52:24Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-10-15T22:17:00Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-10-16T00:01:02Z

@philipgough: All pull requests linked via external trackers have merged:

openshift/cluster-monitoring-operator#1404

Bugzilla bug 2008120 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

philipgough added 3 commits September 29, 2021 07:00

jsonnet: Sync with kube-prometheus

d6abce0

jsonnet: Generate assests

9dd50a0

jsonnet: Patch metric relabelings for control plane

84fb22c

We drop some pod-centric metrics from cAdvisor to reduce cardinality. This metrics are available at the slice level.

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021

philipgough changed the base branch from master to release-4.9 September 29, 2021 06:05

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2021

openshift-ci bot requested review from arajkumar and dgrisonnet September 29, 2021 06:06

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2021

docs: Update changelog

b54a0d6

philipgough marked this pull request as ready for review September 29, 2021 06:09

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2021

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 30, 2021

openshift-ci bot assigned juzhao Sep 30, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 13, 2021

openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 15, 2021

openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 15, 2021

openshift-ci bot requested a review from juzhao October 15, 2021 18:04

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 15, 2021

openshift-merge-robot merged commit fdb2c76 into openshift:release-4.9 Oct 16, 2021

philipgough deleted the bz-2008120 branch October 29, 2021 10:42

Bug 2008120: Adjust dropped cAdvisor metrics #1404

Bug 2008120: Adjust dropped cAdvisor metrics #1404

Conversation

philipgough commented Sep 29, 2021 • edited Loading

openshift-ci bot commented Sep 29, 2021

openshift-ci bot commented Sep 29, 2021

openshift-ci bot commented Sep 29, 2021

openshift-ci bot commented Sep 29, 2021

philipgough commented Sep 29, 2021

philipgough commented Sep 29, 2021

juzhao commented Sep 30, 2021

juzhao commented Sep 30, 2021

openshift-ci bot commented Sep 30, 2021

philipgough commented Sep 30, 2021

philipgough commented Sep 30, 2021

openshift-bot commented Sep 30, 2021

openshift-bot commented Oct 8, 2021

openshift-ci bot commented Oct 8, 2021

openshift-bot commented Oct 9, 2021

openshift-ci bot commented Oct 9, 2021

openshift-bot commented Oct 10, 2021

openshift-ci bot commented Oct 10, 2021

openshift-bot commented Oct 11, 2021

openshift-ci bot commented Oct 11, 2021

openshift-bot commented Oct 12, 2021

openshift-ci bot commented Oct 12, 2021

openshift-bot commented Oct 13, 2021

openshift-ci bot commented Oct 13, 2021

simonpasquier commented Oct 13, 2021

openshift-bot commented Oct 14, 2021

openshift-ci bot commented Oct 14, 2021

openshift-bot commented Oct 15, 2021

openshift-ci bot commented Oct 15, 2021

sdodson commented Oct 15, 2021

openshift-ci bot commented Oct 15, 2021

openshift-ci bot commented Oct 15, 2021 • edited Loading

openshift-bot commented Oct 15, 2021

openshift-bot commented Oct 15, 2021

openshift-ci bot commented Oct 16, 2021

philipgough commented Sep 29, 2021 •

edited

Loading

openshift-ci bot commented Oct 15, 2021 •

edited

Loading