Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2007677: Adjust dropped cAdvisor metrics #1402

Merged
merged 3 commits into from
Sep 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 4.10

- [#1299](https://github.com/openshift/cluster-monitoring-operator/pull/1299) Expose expose /api/v1/labels endpoint for Thanos query.
- [#1402](https://github.com/openshift/cluster-monitoring-operator/pull/1402) Drop pod-centric cAdvisor metrics that are available at slice level.

## 4.9

Expand Down
7 changes: 6 additions & 1 deletion assets/control-plane/service-monitor-kubelet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,19 @@ spec:
- pod
- namespace
- action: drop
regex: (container_fs_.*|container_blkio_device_usage_total);.+
regex: (container_blkio_device_usage_total);.+
sourceLabels:
- __name__
- container
- action: drop
regex: container_memory_failures_total
sourceLabels:
- __name__
- action: drop
regex: (container_fs_.*);.+
sourceLabels:
- __name__
- container
path: /metrics/cadvisor
port: https-metrics
relabelings:
Expand Down
6 changes: 6 additions & 0 deletions jsonnet/components/control-plane.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ function(params)
action: 'drop',
regex: 'container_memory_failures_total',
},
{
// these metrics are available at the slice level
sourceLabels: ['__name__', 'container'],
action: 'drop',
regex: '(container_fs_.*);.+',
},
],
}
else
Expand Down
4 changes: 2 additions & 2 deletions jsonnet/jsonnetfile.lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@
"subdir": "jsonnet/kube-prometheus"
}
},
"version": "211e758dfeae14ac1eb018599d0b141b3b2c3d9c",
"sum": "7Y2gI0uyUCeEpjdhPIOxLs9vHu6cnOUu311HNSN1BiE="
"version": "a2eee1803a074fb40cad109d690732c22f0130cf",
"sum": "kqVnoNBux2YF1s03m+O3w/5jreAnjXx2/NjvNP1Hoy4="
},
{
"source": {
Expand Down