Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-1936: Bump k8s.io dependencies to v0.32.1 #1184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Jan 20, 2025

  • Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.
  • Updated sigs.k8s.io/controller-runtime to v0.20.1 (compatible with k8s v0.32).
  • Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:

go get k8s.io/api@v0.32.1
go get k8s.io/apiextensions-apiserver@v0.32.1
go mod edit -replace k8s.io/client-go=k8s.io/client-go@v0.32.1
go get sigs.k8s.io/controller-runtime@v0.20.1
go mod tidy
go mod vendor

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2025

@alebedev87: This pull request references NE-1936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.
  • Updated sigs.k8s.io/controller-runtime to v0.20.0 (compatible with k8s v0.32).
  • Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:

   go get k8s.io/api@v0.32.1
   go get k8s.io/apiextensions-apiserver@v0.32.1
   go mod edit -replace k8s.io/client-go=k8s.io/client-go@v0.32.1
   go get sigs.k8s.io/controller-runtime@v0.20.0
   go mod tidy
   go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gcs278 and miheer January 20, 2025 21:51
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from alebedev87. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 20, 2025

@alebedev87: This pull request references NE-1936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.
  • Updated sigs.k8s.io/controller-runtime to v0.20.0 (compatible with k8s v0.32).
  • Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:

go get k8s.io/api@v0.32.1
go get k8s.io/apiextensions-apiserver@v0.32.1
go mod edit -replace k8s.io/client-go=k8s.io/client-go@v0.32.1
go get sigs.k8s.io/controller-runtime@v0.20.0
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

/retest

1 similar comment
@alebedev87
Copy link
Contributor Author

/retest

@Miciah
Copy link
Contributor

Miciah commented Jan 22, 2025

/assign

@alebedev87
Copy link
Contributor Author

openshift/origin#29466 is supposed to fix e2e-aws-ocn-serial.

go.mod Outdated
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8
sigs.k8s.io/controller-runtime v0.19.0
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738
sigs.k8s.io/controller-runtime v0.20.0
Copy link
Contributor

@gcs278 gcs278 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.20.1 is out (that was quick). I see two fixes (kubernetes-sigs/controller-runtime#3079 and kubernetes-sigs/controller-runtime#3086) that might be of interest. Up to you if you want to bump again.

https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.20.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I saw they dropped a new one. Let me add it.

@alebedev87 alebedev87 force-pushed the ne-1936-bump-k8s-1-32 branch from bdcd59b to ff1f469 Compare January 24, 2025 16:55
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2025
- Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.
- Updated sigs.k8s.io/controller-runtime to v0.20.1 (compatible with k8s v0.32).
- Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:
    go get k8s.io/api@v0.32.1
    go get k8s.io/apiextensions-apiserver@v0.32.1
    go mod edit -replace k8s.io/client-go=k8s.io/client-go@v0.32.1
    go get sigs.k8s.io/controller-runtime@v0.20.1
    go mod tidy
    go mod vendor
@alebedev87 alebedev87 force-pushed the ne-1936-bump-k8s-1-32 branch from ff1f469 to 6ed63fe Compare January 24, 2025 16:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2025

@alebedev87: This pull request references NE-1936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

  • Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.
  • Updated sigs.k8s.io/controller-runtime to v0.20.1 (compatible with k8s v0.32).
  • Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:

go get k8s.io/api@v0.32.1
go get k8s.io/apiextensions-apiserver@v0.32.1
go mod edit -replace k8s.io/client-go=k8s.io/client-go@v0.32.1
go get sigs.k8s.io/controller-runtime@v0.20.1
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@alebedev87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hypershift-e2e-aks 6ed63fe link true /test hypershift-e2e-aks
ci/prow/e2e-aws-operator-techpreview 6ed63fe link false /test e2e-aws-operator-techpreview
ci/prow/e2e-aws-ovn-single-node 6ed63fe link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants