-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-1936: Bump k8s.io dependencies to v0.32.1 #1184
base: master
Are you sure you want to change the base?
Conversation
@alebedev87: This pull request references NE-1936 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alebedev87: This pull request references NE-1936 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
1 similar comment
/retest |
/assign |
openshift/origin#29466 is supposed to fix |
go.mod
Outdated
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 | ||
sigs.k8s.io/controller-runtime v0.19.0 | ||
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 | ||
sigs.k8s.io/controller-runtime v0.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.20.1 is out (that was quick). I see two fixes (kubernetes-sigs/controller-runtime#3079 and kubernetes-sigs/controller-runtime#3086) that might be of interest. Up to you if you want to bump again.
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.20.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I saw they dropped a new one. Let me add it.
bdcd59b
to
ff1f469
Compare
- Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1. - Updated sigs.k8s.io/controller-runtime to v0.20.1 (compatible with k8s v0.32). - Go version was implicitly bumped to 1.23.0 as part of the dependency updates. Commands used for the upgrade: go get k8s.io/api@v0.32.1 go get k8s.io/apiextensions-apiserver@v0.32.1 go mod edit -replace k8s.io/client-go=k8s.io/client-go@v0.32.1 go get sigs.k8s.io/controller-runtime@v0.20.1 go mod tidy go mod vendor
ff1f469
to
6ed63fe
Compare
@alebedev87: This pull request references NE-1936 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@alebedev87: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Commands used for the upgrade: