NO-JIRA: fix schedule backup test

[Elbehery]

This PR fixes TestNewBackupServer_scheduleBackup due to changes in go1.23 ticker implementation.

Changes that caused the issue

Second, the timer channel associated with a Timer or Ticker is now unbuffered, with capacity 0. The main effect of this change is that Go now guarantees that for any call to a Reset or Stop method, no stale values prepared before that call will be sent or received after the call. Earlier versions of Go used channels with a one-element buffer, making it difficult to use Reset and Stop correctly. A visible effect of this change is that len and cap of timer channels now returns 0 instead of 1, which may affect programs that poll the length to decide whether a receive on the timer channel will succeed. Such code should use a non-blocking receive instead.

[openshift-ci-robot]

@Elbehery: This pull request explicitly references no jira issue.

In response to this:

This PR fixes TestNewBackupServer_scheduleBackup due to changes in go1.23 ticker implementation.

Changes that caused the issue

Second, the timer channel associated with a Timer or Ticker is now unbuffered, with capacity 0. The main effect of this change is that Go now guarantees that for any call to a Reset or Stop method, no stale values prepared before that call will be sent or received after the call. Earlier versions of Go used channels with a one-element buffer, making it difficult to use Reset and Stop correctly. A visible effect of this change is that len and cap of timer channels now returns 0 instead of 1, which may affect programs that poll the length to decide whether a receive on the timer channel will succeed. Such code should use a non-blocking receive instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Elbehery]

/retest-required

[tjungblu]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Elbehery,tjungblu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Elbehery]

/retest-required

[Elbehery]

/lgtm

@tjungblu would u kindly add

acknowledge-critical-fixes-only label as well ?

[tjungblu]

I do not have the permissions, but maybe @dgoodwin can help you

[dgoodwin]

You can both add ack-crit-fixes, it's available to all, just meant to be a self-check to make sure the pr is necessary and safe during a critical time.

[Elbehery]

@tjungblu can we label ?

[tjungblu]

you heard Devan, you can do it yourself :D

[Elbehery]

/label acknowledge-critical-fixes-only

[Elbehery]

/rested-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD fa34bdf and 2 for PR HEAD 708d528 in total

[Elbehery]

/override ci/prow/e2e-aws-ovn-etcd-scaling

[openshift-ci]

@Elbehery: Overrode contexts on behalf of Elbehery: ci/prow/e2e-aws-ovn-etcd-scaling

In response to this:

/override ci/prow/e2e-aws-ovn-etcd-scaling

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown	708d528	link	false	/test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown	708d528	link	false	/test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery	708d528	link	false	/test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator
This PR has been included in build cluster-etcd-operator-container-v4.19.0-202501301707.p0.gb23ae82.assembly.stream.el9.
All builds following this will include this PR.