Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-48523: Bump library-go for static pod controller apply migration fixes. #1387

Merged

Conversation

benluddy
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2025
@openshift-ci-robot
Copy link

@benluddy: This pull request references Jira Issue OCPBUGS-48523, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 16, 2025
@benluddy
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 16, 2025
@openshift-ci-robot
Copy link

@benluddy: This pull request references Jira Issue OCPBUGS-48523, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @geliu2016

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy
Copy link
Contributor Author

/retest-required

@benluddy
Copy link
Contributor Author

I don't think the "etcdctl defrag" test failure is related:

=== RUN   TestEtcdctlCommands/etcdctl_defrag
    etcdctl_test.go:96: 
        	Error Trace:	/go/src/github.com/openshift/cluster-etcd-operator/test/e2e/etcdctl_test.go:96
        	Error:      	Received unexpected error:
        	            	exit status 1
        	Test:       	TestEtcdctlCommands/etcdctl_defrag
        	Messages:   	output was {"level":"warn","ts":"2025-01-17T16:57:21.576214Z","logger":"etcd-client","caller":"v3@v3.5.17/retry_interceptor.go:63","msg":"retrying of unary invoker failed","target":"etcd-endpoints://0xc000474000/10.0.24.90:2379","attempt":0,"error":"rpc error: code = DeadlineExceeded desc = context deadline exceeded"}
        	            	Failed to defragment etcd member[https://10.0.24.90:2379] (context deadline exceeded)
        	            	Finished defragmenting etcd member[https://10.0.31.70:2379]
        	            	Finished defragmenting etcd member[https://10.0.99.173:2379]
        	            	command terminated with exit code 1
    --- FAIL: TestEtcdctlCommands/etcdctl_defrag (6.94s)

Checking the etcd logs from 10.0.24.90, defragmentation starts and eventually finishes, it just takes about 14 seconds:

{"level":"info","ts":"2025-01-17T16:57:16.585475Z","caller":"v3rpc/maintenance.go:92","msg":"starting defragment"}
{"level":"info","ts":"2025-01-17T16:57:30.913524Z","caller":"v3rpc/maintenance.go:100","msg":"finished defragment"}

/test e2e-operator

@benluddy
Copy link
Contributor Author

/retest-required

2 similar comments
@dgrisonnet
Copy link
Member

/retest-required

@benluddy
Copy link
Contributor Author

/retest-required

@hasbro17
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, hasbro17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@hasbro17
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 21, 2025
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@benluddy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery dc7a879 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-operator-fips dc7a879 link false /test e2e-operator-fips
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown dc7a879 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown dc7a879 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation dc7a879 link false /test e2e-aws-etcd-certrotation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hasbro17
Copy link
Contributor

This is an ongoing issue that's unrelated to our change here. Other tests are passing.

3/2434 Tests Failed. | expand_less
-- | --
: [sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial] expand_less5m12s{  fail [github.com/openshift/origin/test/extended/images/signatures.go:40]: Unexpected error:     <*errors.errorString \| 0xc001d9e070>:      timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest     {         s: "timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest",     } occurred Ginkgo exit error 1: exit with code 1} | : [sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial] expand_less | 5m12s | {  fail [github.com/openshift/origin/test/extended/images/signatures.go:40]: Unexpected error:     <*errors.errorString \| 0xc001d9e070>:      timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest     {         s: "timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest",     } occurred Ginkgo exit error 1: exit with code 1}
: [sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial] expand_less | 5m12s
{  fail [github.com/openshift/origin/test/extended/images/signatures.go:40]: Unexpected error:     <*errors.errorString \| 0xc001d9e070>:      timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest     {         s: "timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest",     } occurred Ginkgo exit error 1: exit with code 1}

/override ci/prow/e2e-aws-ovn-serial

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/e2e-aws-ovn-serial

In response to this:

This is an ongoing issue that's unrelated to our change here. Other tests are passing.

3/2434 Tests Failed. | expand_less
-- | --
: [sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial] expand_less5m12s{  fail [github.com/openshift/origin/test/extended/images/signatures.go:40]: Unexpected error:     <*errors.errorString \| 0xc001d9e070>:      timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest     {         s: "timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest",     } occurred Ginkgo exit error 1: exit with code 1} | : [sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial] expand_less | 5m12s | {  fail [github.com/openshift/origin/test/extended/images/signatures.go:40]: Unexpected error:     <*errors.errorString \| 0xc001d9e070>:      timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest     {         s: "timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest",     } occurred Ginkgo exit error 1: exit with code 1}
: [sig-imageregistry][Serial] Image signature workflow can push a signed image to openshift registry and verify it [apigroup:user.openshift.io][apigroup:image.openshift.io] [Skipped:Disconnected] [Suite:openshift/conformance/serial] expand_less | 5m12s
{  fail [github.com/openshift/origin/test/extended/images/signatures.go:40]: Unexpected error:     <*errors.errorString \| 0xc001d9e070>:      timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest     {         s: "timed out while waiting of an image stream tag e2e-test-registry-signing-nrvgp/signer:latest",     } occurred Ginkgo exit error 1: exit with code 1}

/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit fa34bdf into openshift:master Jan 21, 2025
13 of 18 checks passed
@openshift-ci-robot
Copy link

@benluddy: Jira Issue OCPBUGS-48523: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-48523 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator
This PR has been included in build cluster-etcd-operator-container-v4.19.0-202501212037.p0.gfa34bdf.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants