react to changes

pkg/cmd/operator/cmd.go

@@ -13,11 +13,12 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apiserver/pkg/server/healthz"
 	"k8s.io/client-go/tools/record"
+	"k8s.io/utils/clock"
 )
 
 func NewOperator() *cobra.Command {
 	cmd := controllercmd.
-		NewControllerCommandConfig("openshift-cluster-etcd-operator", version.Get(), operator.RunOperator).
+		NewControllerCommandConfig("openshift-cluster-etcd-operator", version.Get(), operator.RunOperator, clock.RealClock{}).
 		WithEventRecorderOptions(EtcdOperatorCorrelatorOptions()).
 		WithHealthChecks(healthz.NamedCheck("controller-aliveness", func(_ *http.Request) error {
 			if !operator.AlivenessChecker.Alive() {

pkg/cmd/render/certs.go

@@ -18,6 +18,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/kubernetes/fake"
 	"k8s.io/component-base/metrics"
+	"k8s.io/utils/clock"
 )
 
 // createCertSecrets will run the etcdcertsigner.EtcdCertSignerController once and collect all respective certs created.
@@ -42,7 +43,7 @@ func createCertSecrets(nodes []*corev1.Node) ([]corev1.Secret, []corev1.ConfigMa
 
 	kubeInformers := v1helpers.NewKubeInformersForNamespaces(fakeKubeClient, "", "kube-system",
 		operatorclient.TargetNamespace, operatorclient.OperatorNamespace, operatorclient.GlobalUserSpecifiedConfigNamespace)
-	recorder := events.NewInMemoryRecorder("etcd")
+	recorder := events.NewInMemoryRecorder("etcd", clock.RealClock{})
 	nodeSelector, err := labels.Parse("node-role.kubernetes.io/master")
 	if err != nil {
 		return nil, nil, fmt.Errorf("could not parse master node labels: %w", err)

pkg/etcdenvvar/envvarcontroller_test.go

@@ -25,6 +25,7 @@ import (
 	"k8s.io/client-go/kubernetes/fake"
 	corev1listers "k8s.io/client-go/listers/core/v1"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 
 	"github.com/stretchr/testify/require"
 
@@ -175,7 +176,7 @@ func TestEnvVarController(t *testing.T) {
 
 			fakeKubeClient := fake.NewSimpleClientset(scenario.objects...)
 			eventRecorder := events.NewRecorder(fakeKubeClient.CoreV1().Events(operatorclient.TargetNamespace),
-				"test-envvarcontroller", &corev1.ObjectReference{})
+				"test-envvarcontroller", &corev1.ObjectReference{}, clock.RealClock{})
 			indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc})
 			for _, obj := range defaultObjects {
 				require.NoError(t, indexer.Add(obj))

pkg/operator/clustermembercontroller/clustermembercontroller_test.go

@@ -22,6 +22,7 @@ import (
 	"k8s.io/client-go/kubernetes/fake"
 	corev1listers "k8s.io/client-go/listers/core/v1"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 )
 
 type fakePodLister struct {
@@ -557,7 +558,7 @@ func TestEnsureEtcdLearnerPromotion(t *testing.T) {
 		t.Run(scenario.name, func(t *testing.T) {
 			// test data
 			fakeMachineAPIChecker := &fakeMachineAPI{isMachineAPIFunctional: scenario.isFunctionalMachineAPIFn}
-			eventRecorder := events.NewRecorder(fake.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-member-controller", &corev1.ObjectReference{})
+			eventRecorder := events.NewRecorder(fake.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-member-controller", &corev1.ObjectReference{}, clock.RealClock{})
 			machineIndexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})
 			for _, initialObj := range scenario.initialObjectsForMachineLister {
 				machineIndexer.Add(initialObj)
@@ -794,7 +795,7 @@ func TestReconcileMembers(t *testing.T) {
 	for _, scenario := range scenarios {
 		t.Run(scenario.name, func(t *testing.T) {
 			// test data
-			eventRecorder := events.NewRecorder(fake.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-member-controller", &corev1.ObjectReference{})
+			eventRecorder := events.NewRecorder(fake.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-member-controller", &corev1.ObjectReference{}, clock.RealClock{})
 			fakeMachineAPIChecker := &fakeMachineAPI{isMachineAPIFunctional: scenario.isFunctionalMachineAPIFn}
 
 			machineIndexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})

pkg/operator/clustermemberremovalcontroller/clustermemberremovalcontroller_test.go

@@ -26,6 +26,7 @@ import (
 	"k8s.io/client-go/kubernetes/fake"
 	corev1listers "k8s.io/client-go/listers/core/v1"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 )
 
 var (
@@ -133,7 +134,7 @@ func TestAttemptToRemoveLearningMember(t *testing.T) {
 	for _, scenario := range scenarios {
 		t.Run(scenario.name, func(t *testing.T) {
 			// test data
-			eventRecorder := events.NewRecorder(fake.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-member-removal-controller", &corev1.ObjectReference{})
+			eventRecorder := events.NewRecorder(fake.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-member-removal-controller", &corev1.ObjectReference{}, clock.RealClock{})
 			configMapTargetNSIndexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})
 			for _, initialObj := range scenario.initialObjectsForConfigMapTargetNSLister {
 				configMapTargetNSIndexer.Add(initialObj)
@@ -1011,7 +1012,7 @@ func TestAttemptToScaleDown(t *testing.T) {
 	for _, scenario := range scenarios {
 		t.Run(scenario.name, func(t *testing.T) {
 			// test data
-			eventRecorder := events.NewRecorder(fake.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-member-removal-controller", &corev1.ObjectReference{})
+			eventRecorder := events.NewRecorder(fake.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-member-removal-controller", &corev1.ObjectReference{}, clock.RealClock{})
 			configMapTargetNSIndexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})
 			for _, initialObj := range scenario.initialObjectsForConfigMapTargetNSLister {
 				configMapTargetNSIndexer.Add(initialObj)

pkg/operator/defragcontroller/defragcontroller_test.go

@@ -26,6 +26,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	corev1listers "k8s.io/client-go/listers/core/v1"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 
 	"github.com/openshift/cluster-etcd-operator/pkg/etcdcli"
 	u "github.com/openshift/cluster-etcd-operator/pkg/testutils"
@@ -165,7 +166,7 @@ func TestNewDefragController(t *testing.T) {
 				etcdcli.WithFakeClusterHealth(scenario.memberHealth),
 				etcdcli.WithFakeStatus(status),
 			)
-			eventRecorder := events.NewInMemoryRecorder(t.Name())
+			eventRecorder := events.NewInMemoryRecorder(t.Name(), clock.RealClock{})
 			require.NoError(t, err)
 			indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc})
 			for _, obj := range scenario.objects {
@@ -324,7 +325,7 @@ func TestNewDefragControllerMultiSyncs(t *testing.T) {
 			}
 
 			fakeEtcdClient, _ := etcdcli.NewFakeEtcdClient(etcdMembers, fakeOpts...)
-			eventRecorder := events.NewInMemoryRecorder(t.Name())
+			eventRecorder := events.NewInMemoryRecorder(t.Name(), clock.RealClock{})
 			require.NoError(t, err)
 			indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc})
 			for _, obj := range scenario.objects {

pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go

@@ -24,6 +24,7 @@ import (
 	"k8s.io/client-go/tools/cache"
 	"k8s.io/component-base/metrics"
 	"k8s.io/component-base/metrics/legacyregistry"
+	"k8s.io/utils/clock"
 
 	"github.com/openshift/library-go/pkg/crypto"
 	"github.com/openshift/library-go/pkg/operator/events"
@@ -592,6 +593,7 @@ func setupController(t *testing.T, objects []runtime.Object, forceSkipRollout bo
 		fakeKubeClient.CoreV1().Events(operatorclient.TargetNamespace),
 		"test-cert-signer",
 		&corev1.ObjectReference{},
+		clock.RealClock{},
 	)
 
 	nodeSelector, err := labels.Parse("node-role.kubernetes.io/master")

pkg/operator/etcdendpointscontroller/etcdendpointscontroller_test.go

@@ -18,6 +18,7 @@ import (
 	corev1listers "k8s.io/client-go/listers/core/v1"
 	clientgotesting "k8s.io/client-go/testing"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 	"k8s.io/utils/diff"
 
 	"github.com/openshift/library-go/pkg/controller/factory"
@@ -324,7 +325,7 @@ func TestBootstrapAnnotationRemoval(t *testing.T) {
 			if err != nil {
 				t.Fatal(err)
 			}
-			eventRecorder := events.NewRecorder(fakeKubeClient.CoreV1().Events(operatorclient.TargetNamespace), "test-etcdendpointscontroller", &corev1.ObjectReference{})
+			eventRecorder := events.NewRecorder(fakeKubeClient.CoreV1().Events(operatorclient.TargetNamespace), "test-etcdendpointscontroller", &corev1.ObjectReference{}, clock.RealClock{})
 			indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc})
 
 			for _, obj := range defaultObjects {

pkg/operator/machinedeletionhooks/machinedeletionhooks_test.go

@@ -16,6 +16,7 @@ import (
 	k8sfakeclient "k8s.io/client-go/kubernetes/fake"
 	clientgotesting "k8s.io/client-go/testing"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 
 	machinev1beta1 "github.com/openshift/api/machine/v1beta1"
 	machinev1beta1fakeclient "github.com/openshift/client-go/machine/clientset/versioned/fake"
@@ -31,7 +32,7 @@ import (
 )
 
 func TestSyncMethod(t *testing.T) {
-	eventRecorder := events.NewRecorder(k8sfakeclient.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-machine-deletion-hooks-controller", &corev1.ObjectReference{})
+	eventRecorder := events.NewRecorder(k8sfakeclient.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-machine-deletion-hooks-controller", &corev1.ObjectReference{}, clock.RealClock{})
 	fakeMachineAPIChecker := &fakeMachineAPI{isMachineAPIFunctional: func() (bool, error) {
 		return false, nil
 	}}
@@ -429,7 +430,7 @@ func TestAttemptToDeleteMachineDeletionHook(t *testing.T) {
 
 	for _, scenario := range scenarios {
 		// test data
-		eventRecorder := events.NewRecorder(k8sfakeclient.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-machine-deletion-hooks-controller", &corev1.ObjectReference{})
+		eventRecorder := events.NewRecorder(k8sfakeclient.NewSimpleClientset().CoreV1().Events("operator"), "test-cluster-machine-deletion-hooks-controller", &corev1.ObjectReference{}, clock.RealClock{})
 		machineIndexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})
 		for _, initialObj := range scenario.initialObjectsForMachineLister {
 			machineIndexer.Add(initialObj)
@@ -658,7 +659,7 @@ func TestAttemptToDeleteQuorumGuard(t *testing.T) {
 	for _, scenario := range scenarios {
 		t.Run(scenario.name, func(t *testing.T) {
 			// We only expect a single event.
-			eventRecorder := events.NewInMemoryRecorder("test-cluster-machine-deletion-hooks-controller")
+			eventRecorder := events.NewInMemoryRecorder("test-cluster-machine-deletion-hooks-controller", clock.RealClock{})
 
 			machineIndexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{})
 			for _, initialObj := range scenario.initialObjectsForMachineLister {

pkg/operator/starter.go

@@ -37,8 +37,6 @@ import (
 	"github.com/openshift/library-go/pkg/operator/status"
 	"github.com/openshift/library-go/pkg/operator/unsupportedconfigoverridescontroller"
 	"github.com/openshift/library-go/pkg/operator/v1helpers"
-	"k8s.io/utils/clock"
-
 	"k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
@@ -174,7 +172,7 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle
 	// we keep the default behavior of exiting the controller once a gate changes
 	featureGateAccessor.SetChangeHandler(featuregates.ForceExit)
 
-	operatorClient, dynamicInformers, err := genericoperatorclient.NewStaticPodOperatorClient(clock.RealClock{}, controllerContext.KubeConfig, operatorv1.GroupVersion.WithResource("etcds"), operatorv1.GroupVersion.WithKind("Etcd"), ExtractStaticPodOperatorSpec, ExtractStaticPodOperatorStatus)
+	operatorClient, dynamicInformers, err := genericoperatorclient.NewStaticPodOperatorClient(controllerContext.Clock, controllerContext.KubeConfig, operatorv1.GroupVersion.WithResource("etcds"), operatorv1.GroupVersion.WithKind("Etcd"), ExtractStaticPodOperatorSpec, ExtractStaticPodOperatorStatus)
 	if err != nil {
 		return err
 	}
@@ -304,7 +302,7 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle
 		return quorumChecker.IsSafeToUpdateRevision()
 	}
 
-	staticPodControllers, err := staticpod.NewBuilder(operatorClient, kubeClient, kubeInformersForNamespaces, configInformers).
+	staticPodControllers, err := staticpod.NewBuilder(operatorClient, kubeClient, kubeInformersForNamespaces, configInformers, controllerContext.Clock).
 		WithEvents(controllerContext.EventRecorder).
 		WithInstaller([]string{"cluster-etcd-operator", "installer"}).
 		WithPruning([]string{"cluster-etcd-operator", "prune"}, "etcd-pod").
@@ -429,6 +427,7 @@ func RunOperator(ctx context.Context, controllerContext *controllercmd.Controlle
 	)
 
 	unsupportedConfigOverridesController := unsupportedconfigoverridescontroller.NewUnsupportedConfigOverridesController(
+		"etcd",
 		operatorClient,
 		controllerContext.EventRecorder,
 	)

pkg/operator/targetconfigcontroller/targetconfigcontroller_test.go

@@ -23,6 +23,7 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/kubernetes/fake"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 
 	"github.com/stretchr/testify/require"
 )
@@ -151,7 +152,7 @@ func getController(t *testing.T, staticPodStatus *operatorv1.StaticPodOperatorSt
 	}
 
 	eventRecorder := events.NewRecorder(fakeKubeClient.CoreV1().Events(operatorclient.TargetNamespace),
-		"test-targetconfigcontroller", &corev1.ObjectReference{})
+		"test-targetconfigcontroller", &corev1.ObjectReference{}, clock.RealClock{})
 	indexer := cache.NewIndexer(cache.MetaNamespaceKeyFunc, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc})
 	for _, obj := range defaultObjects {
 		require.NoError(t, indexer.Add(obj))

pkg/tlshelpers/target_cert_creator_test.go

@@ -25,6 +25,7 @@ import (
 	kubefake "k8s.io/client-go/kubernetes/fake"
 	corev1listers "k8s.io/client-go/listers/core/v1"
 	"k8s.io/client-go/tools/cache"
+	"k8s.io/utils/clock"
 )
 
 type testEmbed struct {
@@ -111,7 +112,7 @@ func TestSignerSignatureRotation(t *testing.T) {
 
 				Client:        client.CoreV1(),
 				Lister:        corev1listers.NewSecretLister(indexer),
-				EventRecorder: events.NewInMemoryRecorder("test"),
+				EventRecorder: events.NewInMemoryRecorder("test", clock.RealClock{}),
 			}
 
 			ca, err := test.caFn()