forked from kubernetes-sigs/cluster-api-provider-azure
-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
UPSTREAM: <carry>: openshift: services: add service to handle applica…
…tion security groups Appliation security groups allow grouping machines for network firewall purpose. This allows writing smarter and compact network security group rules. see more info: https://docs.microsoft.com/en-us/azure/virtual-network/security-overview#application-security-groups
- Loading branch information
1 parent
08ab433
commit 21aa5c6
Showing
2 changed files
with
156 additions
and
0 deletions.
There are no files selected for viewing
110 changes: 110 additions & 0 deletions
110
pkg/cloud/azure/services/applicationsecuritygroups/applicationsecuritygroups.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
/* | ||
Copyright 2019 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package applicationsecuritygroups | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/Azure/azure-sdk-for-go/services/network/mgmt/2018-12-01/network" | ||
"github.com/Azure/go-autorest/autorest/to" | ||
"github.com/pkg/errors" | ||
"k8s.io/klog" | ||
"sigs.k8s.io/cluster-api-provider-azure/pkg/cloud/azure" | ||
) | ||
|
||
// Spec specification for network application security groups | ||
type Spec struct { | ||
Name string | ||
} | ||
|
||
// Get provides information about a route table. | ||
func (s *Service) Get(ctx context.Context, spec azure.Spec) (interface{}, error) { | ||
asgSpec, ok := spec.(*Spec) | ||
if !ok { | ||
return network.ApplicationSecurityGroup{}, errors.New("invalid application security groups specification") | ||
} | ||
applicationSecurityGroup, err := s.Client.Get(ctx, s.Scope.ClusterConfig.ResourceGroup, asgSpec.Name) | ||
if err != nil && azure.ResourceNotFound(err) { | ||
return nil, errors.Wrapf(err, "application security group %s not found", asgSpec.Name) | ||
} else if err != nil { | ||
return applicationSecurityGroup, err | ||
} | ||
return applicationSecurityGroup, nil | ||
} | ||
|
||
// CreateOrUpdate creates or updates a route table. | ||
func (s *Service) CreateOrUpdate(ctx context.Context, spec azure.Spec) error { | ||
asgSpec, ok := spec.(*Spec) | ||
if !ok { | ||
return errors.New("invalid application security groups specification") | ||
} | ||
|
||
klog.V(2).Infof("creating application security group %s", asgSpec.Name) | ||
f, err := s.Client.CreateOrUpdate( | ||
ctx, | ||
s.Scope.ClusterConfig.ResourceGroup, | ||
asgSpec.Name, | ||
network.ApplicationSecurityGroup{ | ||
Location: to.StringPtr(s.Scope.ClusterConfig.Location), | ||
}, | ||
) | ||
if err != nil { | ||
return errors.Wrapf(err, "failed to create application security group %s in resource group %s", asgSpec.Name, s.Scope.ClusterConfig.ResourceGroup) | ||
} | ||
|
||
err = f.WaitForCompletionRef(ctx, s.Client.Client) | ||
if err != nil { | ||
return errors.Wrap(err, "cannot create, future response") | ||
} | ||
|
||
_, err = f.Result(s.Client) | ||
if err != nil { | ||
return errors.Wrap(err, "result error") | ||
} | ||
klog.V(2).Infof("created application security group %s", asgSpec.Name) | ||
return err | ||
} | ||
|
||
// Delete deletes the route table with the provided name. | ||
func (s *Service) Delete(ctx context.Context, spec azure.Spec) error { | ||
asgSpec, ok := spec.(*Spec) | ||
if !ok { | ||
return errors.New("invalid application security groups specification") | ||
} | ||
klog.V(2).Infof("deleting application security group %s", asgSpec.Name) | ||
f, err := s.Client.Delete(ctx, s.Scope.ClusterConfig.ResourceGroup, asgSpec.Name) | ||
if err != nil && azure.ResourceNotFound(err) { | ||
// already deleted | ||
return nil | ||
} | ||
if err != nil { | ||
return errors.Wrapf(err, "failed to delete application security group %s in resource group %s", asgSpec.Name, s.Scope.ClusterConfig.ResourceGroup) | ||
} | ||
|
||
err = f.WaitForCompletionRef(ctx, s.Client.Client) | ||
if err != nil { | ||
return errors.Wrap(err, "cannot create, future response") | ||
} | ||
|
||
_, err = f.Result(s.Client) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
klog.V(2).Infof("deleted application security group %s", asgSpec.Name) | ||
return err | ||
} |
46 changes: 46 additions & 0 deletions
46
pkg/cloud/azure/services/applicationsecuritygroups/service.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/* | ||
Copyright 2019 The Kubernetes Authors. | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package applicationsecuritygroups | ||
|
||
import ( | ||
"github.com/Azure/azure-sdk-for-go/services/network/mgmt/2018-12-01/network" | ||
"github.com/Azure/go-autorest/autorest" | ||
"sigs.k8s.io/cluster-api-provider-azure/pkg/cloud/azure" | ||
"sigs.k8s.io/cluster-api-provider-azure/pkg/cloud/azure/actuators" | ||
) | ||
|
||
// Service provides operations on resource groups | ||
type Service struct { | ||
Client network.ApplicationSecurityGroupsClient | ||
Scope *actuators.Scope | ||
} | ||
|
||
// getGroupsClient creates a new groups client from subscriptionid. | ||
func getApplicationSecurityGroupsClient(subscriptionID string, authorizer autorest.Authorizer) network.ApplicationSecurityGroupsClient { | ||
applicationSecurityGroupsClient := network.NewApplicationSecurityGroupsClient(subscriptionID) | ||
applicationSecurityGroupsClient.Authorizer = authorizer | ||
applicationSecurityGroupsClient.AddToUserAgent(azure.UserAgent) | ||
return applicationSecurityGroupsClient | ||
} | ||
|
||
// NewService creates a new groups service. | ||
func NewService(scope *actuators.Scope) azure.Service { | ||
return &Service{ | ||
Client: getApplicationSecurityGroupsClient(scope.SubscriptionID, scope.Authorizer), | ||
Scope: scope, | ||
} | ||
} |